bootc-ubuntu-setup: Also update buildah#34
Conversation
Used by the buildah-build action: https://github.com/redhat-actions/buildah-build Signed-off-by: Timothée Ravier <tim@siosm.fr>
travier
force-pushed
the
main-update-buildah
branch
from
4d6bd51 to
063c8eb
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds buildah/plucky to the package installation list in the Ubuntu setup action. The review feedback highlights the stability risks of mixing packages from a future release with an LTS base due to potential glibc dependency conflicts and suggests improving the readability of the installation command by splitting it into multiple lines.
| /bin/time -f '%E %C' sudo apt update | ||
| # skopeo is currently older in plucky for some reason hence --allow-downgrades | ||
| /bin/time -f '%E %C' sudo apt install -y --allow-downgrades crun/plucky podman/plucky skopeo/plucky just | ||
| /bin/time -f '%E %C' sudo apt install -y --allow-downgrades crun/plucky buildah/plucky podman/plucky skopeo/plucky just |
There was a problem hiding this comment.
Mixing packages from a future release (plucky) with an LTS base (noble) is risky. As plucky (25.04) evolves, its packages will eventually depend on a newer version of libc6 (glibc) than what is available in Ubuntu 24.04. This can lead to broken dependencies or a failed installation that renders the runner unusable. Consider using official static binaries for a more stable way to get the latest container tools in CI.
| /bin/time -f '%E %C' sudo apt update | ||
| # skopeo is currently older in plucky for some reason hence --allow-downgrades | ||
| /bin/time -f '%E %C' sudo apt install -y --allow-downgrades crun/plucky podman/plucky skopeo/plucky just | ||
| /bin/time -f '%E %C' sudo apt install -y --allow-downgrades crun/plucky buildah/plucky podman/plucky skopeo/plucky just |
There was a problem hiding this comment.
For better readability and easier maintenance of this package list, consider splitting the apt install command into multiple lines.
/bin/time -f '%E %C' sudo apt install -y --allow-downgrades \
crun/plucky \
buildah/plucky \
podman/plucky \
skopeo/plucky \
just1 participant
Used by the buildah-build action: https://github.com/redhat-actions/buildah-build