Naming Conventions#427
Open
dellaert wants to merge 2 commits into
Open
Conversation
…nd consistency - Renamed `BasisKeyFunc` to `BasisKeyFunction` for better readability. - Updated various instances of `params->retractor_creator` to `params->retractorCreator` for consistency across the codebase. - Changed references from `TspaceBasis` to `TangentSpaceBasis` to reflect naming conventions. - Modified test cases to align with new naming conventions and improved parameter structures. - Enhanced readability by using camelCase for parameter names and method calls. - Ensured that all tests related to the constraint manifold and its components are updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for moving some of this stuff to GTSAM, I would like to make these naming changes that are more compliant. I realize it's a big diff but it's very mechanical. My main concern is, @yetongatech , that you start are OK using this and and that you don't have outstanding branches which will create large conflicts.