Skip to content

fix(bounty): derive shortlist selection from live application list #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xdevcollins merged 1 commit into from
Jul 5, 2026
Merged

fix(bounty): derive shortlist selection from live application list #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions components/organization/bounties/manage/BountyApplicationsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ export default function BountyApplicationsPanel({
a.applicationStatus === 'SUBMITTED';
const busy = select.isPending || shortlist.isPending || decline.isPending;

// `checked` can hold ids that have since left SUBMITTED (e.g. a checked
// application was declined, unmounting its checkbox), so derive the
// effective selection from the live list: the sticky-bar count and the
// shortlist payload must never include a non-actionable application.
const selectedIds = [...checked].filter(id =>
applications.some(a => a.id === id && actionable(a))
);

const toggleCheck = (id: string) =>
setChecked(prev => {
const next = new Set(prev);
Expand All @@ -122,7 +130,7 @@ export default function BountyApplicationsPanel({
);

const onShortlist = () => {
const applicationIds = [...checked];
const applicationIds = selectedIds;
if (
overview.shortlistSize != null &&
applicationIds.length > overview.shortlistSize
Expand Down Expand Up @@ -171,19 +179,19 @@ export default function BountyApplicationsPanel({
{isCompetition && (
<div className='sticky bottom-4 flex items-center justify-between gap-3 rounded-2xl border border-zinc-800 bg-zinc-950/90 p-4 backdrop-blur'>
<span className='text-sm text-zinc-400'>
{checked.size} selected
{selectedIds.length} selected
{overview.shortlistSize != null
? ` (max ${overview.shortlistSize})`
: ''}
</span>
<BoundlessButton
disabled={checked.size === 0 || busy}
disabled={selectedIds.length === 0 || busy}
onClick={onShortlist}
>
{shortlist.isPending ? (
<Loader2 className='h-4 w-4 animate-spin' />
) : (
`Approve shortlist (${checked.size})`
`Approve shortlist (${selectedIds.length})`
)}
</BoundlessButton>
</div>
Expand Down
Loading