Port some Hermes-3 finite volume operators (rebased)#3335
Open
dschwoerer wants to merge 19 commits into
Open
Conversation
Includes bug fix: ```diff - BoutReal gL = n.c - n.L; - BoutReal gR = n.R - n.c; + BoutReal gL = n.c - n.m; + BoutReal gR = n.p - n.c; ```
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
A couple of points that haven't been done:
|
|
|
||
| Field3D Div_par_K_Grad_par_mod(const Field3D& Kin, const Field3D& fin, Field3D& flow_ylow, | ||
| bool bndry_flux) { | ||
| TRACE("FV::Div_par_K_Grad_par_mod"); |
Contributor
There was a problem hiding this comment.
warning: no header providing "TRACE" is directly included [misc-include-cleaner]
src/mesh/difops.cxx:27:
- #include <bout/assert.hxx>
+ #include "bout/index_derivs_interface.hxx"
+ #include <bout/assert.hxx>| Field3D result{zeroFrom(fin)}; | ||
| flow_ylow = zeroFrom(fin); | ||
|
|
||
| BOUT_FOR(i, result.getRegion("RGN_NOBNDRY")) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "BOUT_FOR" is directly included [misc-include-cleaner]
src/mesh/difops.cxx:27:
- #include <bout/assert.hxx>
+ #include "bout/region.hxx"
+ #include <bout/assert.hxx>| #include "bout/options.hxx" | ||
| #include "bout/options_io.hxx" | ||
| #include "bout/utils.hxx" | ||
|
|
Contributor
There was a problem hiding this comment.
warning: included header utils.hxx is not used directly [misc-include-cleaner]
Suggested change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #3200 on top of #3320 and #3334