fix(content-sharing): vanity name permission#4530
fix(content-sharing): vanity name permission#4530reneshen0328 wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThree files were updated to surface vanity-name availability: the mock API response adds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
| isDownloadEnabled: isDownloadAllowed, | ||
| isPasswordAvailable: isPasswordAvailable ?? false, | ||
| isPasswordEnabled, | ||
| isVanityNameAvailable: isVanityNameAvailable ?? false, |
There was a problem hiding this comment.
@reneshen0328 a few lines above, you commented vanity URLs cannot be set via the API, so how does that impact this?
There was a problem hiding this comment.
isVanityNameAvailable controls if the user can see the section whereas canChangeVanityName controls if the user can edit the toggle setting. My changes only render the section if it's available. It will always be greyed out even if the user can see the section.
There was a problem hiding this comment.
maybe this is outdated, the API docs says that you can update the vanity name: https://developer.box.com/reference/put-files-id--add-shared-link#body-shared-link-vanity-name
There was a problem hiding this comment.
hmm yeah I'll look into this more
There was a problem hiding this comment.
@reneshen0328 I think you can do that in a follow up
1b42e39 to
e06fccb
Compare
Summary by CodeRabbit