Skip to content

Fix short article column layout#163

Open
taherdhanera wants to merge 1 commit into
breck7:mainfrom
taherdhanera:fix-short-article-column-layout-32
Open

Fix short article column layout#163
taherdhanera wants to merge 1 commit into
breck7:mainfrom
taherdhanera:fix-short-article-column-layout-32

Conversation

@taherdhanera
Copy link
Copy Markdown

/claim #32

Fixes #32.

Summary

  • Change Scroll column layout to fill columns vertically before balancing into extra columns.
  • Give short article column containers a viewport-height minimum so one-page articles no longer spread sparse content across too many columns.

Verification

  • node -e "const fs=require('fs'); const css=fs.readFileSync('external/.scroll.css','utf8'); console.log(css.includes('column-fill: auto;') && css.includes('min-height: 100vh;') ? 'css check passed' : 'css check failed')"

Notes

  • npm test and npm run build currently fail on this checkout before this CSS change because the installed scrollsdk exposes scrollProgram without the load() method expected by scroll.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Fix bad layout issues on short single page articles

1 participant