Add after_forks_complete configuration hook#120
Open
supairish wants to merge 2 commits intobriandunn:masterfrom
Open
Add after_forks_complete configuration hook#120supairish wants to merge 2 commits intobriandunn:masterfrom
supairish wants to merge 2 commits intobriandunn:masterfrom
Conversation
Author
|
Note: the CI failure is a pre-existing RuboCop offense on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
after_forks_completehook toFlatware::Configuration, called once in the sink process after all workers have finished and all work is complete (just beforeDRb.stop_service).This complements the existing
before_forkandafter_forkhooks by providing a place to run teardown logic that should happen exactly once after the entire parallel run — for example, cleaning up shared test databases or aggregating results.Usage
Changes
lib/flatware/configuration.rb— addsafter_forks_completeaccessor with the same pattern asbefore_fork/after_forklib/flatware/sink.rb— calls the hook incheck_finished!before stopping DRbspec/flatware/configuration_spec.rb— tests default noop behavior and block storageTest plan