fix(PE-1451): correct MatchFiles usage in autozip.brs DoesFileExist - #130
Open
evan-morgan wants to merge 1 commit into
Open
fix(PE-1451): correct MatchFiles usage in autozip.brs DoesFileExist#130evan-morgan wants to merge 1 commit into
evan-morgan wants to merge 1 commit into
Conversation
…ory and separator-free pattern
evan-morgan
requested review from
bhastings1019,
blshukla,
jdmedlin1 and
lherlein
August 7, 2026 06:26
bhastings1019
approved these changes
Aug 7, 2026
blshukla
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
DoesFileExist()in the autorun.zip example'sautozip.brsalways returnedfalse, even when the target file existed, because it calledMatchFiles(filePath$, filePath$)with the full file path as both arguments. Per the BrightSignMatchFiles(path, pattern_in)contract, the first argument must be a directory and the pattern must not contain a directory separator, otherwise it returns zero results. This broke the zip-exists and already-extracted checks that drive the whole extraction flow.Issue: PE-1451
📋 List of Changes
DoesFileExist()now splits the incoming path into its directory and filename parts and callsMatchFiles(dirPath$, fileName$)correctly.🧪 Steps to Test
autorun-zip-packageexample and placeautorun.zipat the root of an SD card.autorun.zip.done, and the player reboots into the extracted app instead of failing theDoesFileExistcheck.Notes to the Reviewer
Root cause was confirmed against the BrightSign developer docs (
Global Functions > MatchFiles) and against a debugger repro from a partner (Guillaume Proux) showingMatchFiles("SD:", "autorun.zip")succeeds whileMatchFiles("SD:/autorun.zip", "SD:/autorun.zip")does not.📸 Screenshots
N/A
✔️ Dev Complete Checklist