fix null join key handling in hash join - #7238
Merged
Merged
Conversation
nwt
marked this pull request as draft
August 24, 2026 15:33
The hash join implementation considers join keys to be matching if both are null. Per SQL they do not match so fix this.
nwt
force-pushed
the
hash-join-null-key
branch
from
August 26, 2026 01:09
9212301 to
c077586
Compare
nwt
marked this pull request as ready for review
August 26, 2026 01:11
mattnibs
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash join implementation considers join keys to be matching if both are null. Per SQL they do not match so fix that.
Fixes #7223.