-
Notifications
You must be signed in to change notification settings - Fork 81
Fix some nits in the book docs to avoid codespell exceptions #7242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ while modified fields are mutated in place. | |
| If multiple fields are written in a single `put`, all the new field values are | ||
| computed first and then they are all written simultaneously. As a result, | ||
| a computed value cannot be referenced in another expression. If you need | ||
| to re-use a computed result, this can be done by chaining multiple `put` operators. | ||
| to reuse a computed result, this can be done by chaining multiple `put` operators. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While both "re-use" and "reuse" are considered acceptable spellings in general, a web search indicates that the former spelling is used ~10-15% of the time in typical writing, so codespell flags it it by default. We currently have 10 instances of "reuse" elsewhere in the repo and this was the only "re-use". |
||
|
|
||
| The `put` keyword is optional since it can be used as a [shortcut](intro.md#shortcuts). | ||
| When used as a shortcut, the `<field>:=` portion of `<assignment>` is not optional. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codespell happens to flag "rouge" as a likely misspelling of "rogue". While we don't currently use "rogue" anywhere in the repo, it may come up, so rather than add an exception that could cause us to miss a real typo down the road, since this read as an arbitrary trio of small/medium/large cities, I'm proposing using a different city that happens to match the default codespell dictionary. And since this example appears verbatim in a ztest, I changed it there to match.