optimizer: make optimizeSourcePaths work with sub queries - #7248
Merged
Conversation
mattnibs
commented
Aug 26, 2026
| } | ||
| } | ||
|
|
||
| func WalkTWithError[T any](v reflect.Value, post func(T) (T, error)) error { |
Collaborator
Author
There was a problem hiding this comment.
@nwt I don't like adding this, would be better to have a single WalkT but there are places where optimizer returns errors during analysis. My intuition is that the optimizer should just panic when it encounters errors since these should have already been caught in the semantic pass- stuff like a length 0 sequential, an unexpected source operator, a failed pool lookup, etc.
Member
There was a problem hiding this comment.
I think your intuition is probably right.
nwt
approved these changes
Aug 27, 2026
| } | ||
| } | ||
|
|
||
| func WalkTWithError[T any](v reflect.Value, post func(T) (T, error)) error { |
Member
There was a problem hiding this comment.
I think your intuition is probably right.
mattnibs
force-pushed
the
subquery-optimize
branch
from
August 27, 2026 21:14
b595c83 to
76a243d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6206