Conversation
This commit adds preliminary support for dealing with option types.
The ?? is the none-ish coalescing operator and ?. is the optional chaining
operator similar to typescript.
In subsequent commits, we will add Comprehensive type checking with respect
to option types and runtime logic that will generate structured errors when
none values are encountered instead of error("missing").
nwt
approved these changes
Aug 26, 2026
| if table == "" || s.table == table { | ||
| for _, col := range s.typ.Fields { | ||
| out = append(out, sem.NewThis(n, append(slices.Clone(path), col.Name))) | ||
| path := sem.NewPath(append(slices.Clone(path), col.Name)...) |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| path := sem.NewPath(append(slices.Clone(path), col.Name)...) | |
| path := append(sem.NewPath(path...), sem.PathElem{ID: col.Name}) |
Comment on lines
92
to
94
| case *vector.None: | ||
| return true | ||
| case *vector.Null: |
Member
There was a problem hiding this comment.
Nit: None comes after null.
Suggested change
| case *vector.None: | |
| return true | |
| case *vector.Null: | |
| case *vector.Null: | |
| return true | |
| case *vector.None: |
| if !super.IsOptionType(u.Type()) { | ||
| return u | ||
| } | ||
| v := u.Normalized() |
Member
There was a problem hiding this comment.
Nit: We usually say vec.
Suggested change
| v := u.Normalized() | |
| vec := u.Normalized() |
| } | ||
| d := u.Dynamic() | ||
| vecs := make([]Any, 0, len(d.Values)) | ||
| for _, v := range d.Values { |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| for _, v := range d.Values { | |
| for _, vec := range d.Values { |
|
|
||
| func (u *Union) IsNormalizedOption() bool { | ||
| var cnt int | ||
| for _, v := range u.Values() { |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| for _, v := range u.Values() { | |
| for _, vec := range u.Values() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds preliminary support for dealing with option types. The ?? is the none-ish coalescing operator and ?. is the optional chaining operator similar to typescript.
In subsequent commits, we will add Comprehensive type checking with respect to option types and runtime logic that will generate structured errors when none values are encountered instead of error("missing").