Skip to content

runtime/vam/op: make map with expected size in HashJoin.buildTable #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Aug 27, 2026
Merged

runtime/vam/op: make map with expected size in HashJoin.buildTable #7253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions runtime/vam/op/hashjoin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ func (h *HashJoin) tableInit() error {
var table map[string][]super.Value
var left, right vio.Puller
if rightBuf.EOS {
table, err = buildTable(rightBuf, h.rightKey)
table = buildTable(rightBuf.vecs, h.rightKey)
left = leftBuf
} else {
table, err = buildTable(leftBuf, h.leftKey)
table = buildTable(leftBuf.vecs, h.leftKey)
right = rightBuf
}
h.hashJoin = &hashJoin{
Expand All @@ -97,17 +97,17 @@ func (h *HashJoin) tableInit() error {
rightKey: h.rightKey,
hits: make(map[string]bool),
}
return err
return nil
}

func buildTable(p vio.Puller, key expr.Evaluator) (map[string][]super.Value, error) {
func buildTable(vecs []vector.Any, key expr.Evaluator) map[string][]super.Value {
var n int
for _, vec := range vecs {
n += int(vec.Len())
}
table := make(map[string][]super.Value, n)
var sb scode.Builder
table := map[string][]super.Value{}
for {
vec, err := p.Pull(false)
if vec == nil || err != nil {
return table, err
}
for _, vec := range vecs {
rightKeyVec := key.Eval(vec)
for i := range vec.Len() {
keyVal := vector.ValueAt(&sb, rightKeyVec, i)
Expand All @@ -118,6 +118,7 @@ func buildTable(p vio.Puller, key expr.Evaluator) (map[string][]super.Value, err
table[key] = append(table[key], vector.ValueAt(&sb, vec, i).Copy())
}
}
return table
}

// pullRace pulls from a and b concurrently until one reaches EOS. It returns
Expand Down
Loading