runtime/vam/op: use scode.Builder.Truncate in hashJoin.wrap - #7255
Draft
nwt wants to merge 1 commit into
Draft
Conversation
This noticeably improves wrap performance by eliminating allocations. Switching from Builder.Reset to Truncate is safe because the super.Value returned by any call to wrap is unreachable when the next call occurs.
nwt
marked this pull request as draft
August 28, 2026 00:03
mattnibs
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This noticeably improves wrap performance by eliminating allocations. Switching from Builder.Reset to Truncate is safe because the super.Value returned by any call to wrap is unreachable when the next call occurs.