Use an explicit source in program.test.ts - #3219
Closed
philrz wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@nwt has confirmed that my proposed change here is indeed just papering over an underlying problem. The test failure is believed to be an accureate reflection of features in the app (probably related to pins) that no longer work due to an API change, so at some point someone will do the work to fix the app. In the meantime, closing this PR without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In contemplating #3218, @nwt remarked:
Therefore in this branch I've added explicit leading
from testto the queries, which gets the tests to pass again with the newer SuperDB dependency.