Skip to content

Use an explicit source in program.test.ts - #3219

Closed
philrz wants to merge 1 commit into
mainfrom
explicit-source-in-test
Closed

Use an explicit source in program.test.ts#3219
philrz wants to merge 1 commit into
mainfrom
explicit-source-in-test

Conversation

@philrz

@philrz philrz commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

In contemplating #3218, @nwt remarked:

This ultimately traces back to the change we made to the HTTP API to ignore the pool name zui sends along side a query. That pool was treated as a default source if the query didn't include an explicit source. Without it, you get the null source. And with type checking against the null source instead of a pool, you get errors.

Therefore in this branch I've added explicit leading from test to the queries, which gets the tests to pass again with the newer SuperDB dependency.

@philrz philrz self-assigned this Dec 26, 2025
@philrz
philrz requested a review from nwt December 26, 2025 22:05
@philrz

philrz commented Dec 29, 2025

Copy link
Copy Markdown
Contributor Author

@nwt has confirmed that my proposed change here is indeed just papering over an underlying problem. The test failure is believed to be an accureate reflection of features in the app (probably related to pins) that no longer work due to an API change, so at some point someone will do the work to fix the app. In the meantime, closing this PR without merging.

@philrz philrz closed this Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant