Drop SBOM release-asset upload under immutable releases - #447
Merged
Conversation
Immutable releases reject asset changes after publish, and UploadPyPI runs on the release:created event that fires only once the release is already published, so the gh release upload step could never attach the SBOM. Remove the step, drop the job back to contents: read (clearing Scorecard #160), and drop the now-unused uploads.github.com egress endpoint. The SBOM still ships as a digest-bound attestation.
btschwertfeger
added
Release
CI/CD
btschwertfeger
added a commit
that referenced
this pull request
Jul 30, 2026
PR #447 dropped the `gh release upload` step that attached `sbom.cdx.json` to the GitHub Release, since immutable releases make a release-time asset upload unworkable from a job triggered on `release: created`. The comment above the SBOM generation step still described that removed behavior. The SBOM now reaches consumers only as the digest-bound attestation written by `actions/attest-sbom`, so the comment says that instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UploadPyPIattached the SBOM withgh release upload, but immutable releases reject asset changes after publish and the job runs onrelease: created, which fires only once the release is already published. The step could never attach the SBOM. The SBOM still ships as a digest-bound attestation, and PEP 770 will embed it in the wheel oncesetuptoolssupports it.Dropping the step also returns the job to
contents: read, clearing Scorecard alert https://github.com/btschwertfeger/python-kraken-sdk/security/code-scanning/160.