added continuous locomotion + hand presence bug fixes#3
Open
NullReality wants to merge 14 commits into
Open
Conversation
* adjust shader type to fix dotted line not animating. * also removed duplicate .gitignore file and adjusted it to work in root directory
+ added continuous locomotion using left primary gamepad * modified left hand scripts to properly render controller * organized movement scripts into their own folder * changed Time step to 0.11111
hand presence script now works as intended. no more duplicate hand models, no more errors :)
bubblesunyum
approved these changes
Feb 13, 2022
bubblesunyum
left a comment
bubblesunyum
left a comment
Owner
There was a problem hiding this comment.
nice code, bro! you've gotten a lot better at naming and organizing over the years 😍
| character.Move(direction * Time.fixedDeltaTime * speed); | ||
|
|
||
| // gravity | ||
| bool isGrounded = CheckIfGrounded(); |
Owner
There was a problem hiding this comment.
conventionally, boolean methods are named something like isGrounded() -- might be nice to do that to avoid verbosity
| bool isGrounded = CheckIfGrounded(); | ||
|
|
||
| if(isGrounded) | ||
| fallingSpeed = 0; |
Owner
There was a problem hiding this comment.
when not using braces, it's a good idea to keep the body code on the same line
Collaborator
Author
There was a problem hiding this comment.
really? i find that would make extremely confusing for me when i come back and read it again.
Owner
|
why does it say that it can't be rebased due to conflicts? |
…of materials + flyer board
…t beam + hdri skybox + updates vscode version
… lighting profile + improved some art specular levels + added staff photos and billboard + fixed floating XR Origin camera in builds
Collaborator
Author
Not sure? It says no conflicts on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.