feat: provide iConfiguration descriptor in enumerator if present#215
Closed
facchinm wants to merge 3 commits into
Closed
feat: provide iConfiguration descriptor in enumerator if present#215facchinm wants to merge 3 commits into
facchinm wants to merge 3 commits into
Conversation
facchinm
added a commit
to facchinm/serial-discovery
that referenced
this pull request
Apr 20, 2026
facchinm
added a commit
to arduino/ArduinoCore-zephyr
that referenced
this pull request
Apr 20, 2026
…needed Requires arduino/arduino-cli#3171 and arduino/serial-discovery#116 (and, transitively, bugst/go-serial#215) TODO: * replace the shell script with a proper version check utility * check if other uploaders need different methods
Member
|
Thanks for the patch @facchinm I've added some work to retrieve the iManufacturer and iProduct strings, I'll open a new PR including your changes shortly. |
Member
|
Superseded by #218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows the enumerator to report iConfiguration descriptor; the implementation of Windows and macOS is heavily AI-based but tested on real hardware (both with and without the aformentioned descriptor).
Can be tested with https://github.com/arduino/ArduinoCore-zephyr/commits/loader_version_iconfig on any hardware with native USB (I used a Giga)