feat: metadata search UI in the workspace file browser (#159)#165
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-web | 627725e | Commit Preview URL Branch Preview URL |
Jul 14 2026, 02:39 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-api | 627725e | Commit Preview URL Branch Preview URL |
Jul 14 2026, 02:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a metadata search surface to the web, folded into the existing per-workspace file browser on
/account/workspaces. Implements the "Web search UI" follow-up from #159 — the CLI/MCP filter path shipped in #157 is now reachable from the browser.What's in it
GET /me/workspaces/:name/files/search?meta.<key>=<value>(me.ts). Reuses the shippedvalidateMetadataFilters/findObjectsByMetadatahelpers; AND-of-equality semantics; member-gated; communal → empty; caps at 100 with atruncatedflag.workspace-search-url.ts: filter validation + URL sync), asearchWorkspaceFilesAPI client,MetadataSearchResults(filter chips + results list with thumbnail/filename/metadata/open+copy), and aWorkspaceFileswrapper that switches the browser between folder-browse and search.AccountFileBrowseris untouched.Design & plan
docs/superpowers/specs/2026-07-14-metadata-search-ui-design.mddocs/superpowers/plans/2026-07-14-metadata-search-ui.mdScope / accepted tradeoffs
visibilityannotation (it isn't in the D1 index — documented Per-file metadata: post-ship follow-ups (#157/#158) #159 caveat); search results have no visibility toggle by design.Testing
346/346, web92/92green; typecheck clean.:name+ staticfiles/search) is not the fix: metadata endpoints 404 on real keys in production #158{.+}-suffix trap and matches deployed siblings (file-url,files/visibility,file-browser)..dev.vars). Please verify on the deploy preview: add a filter (e.g.gh.repo), confirm results render andGET .../files/searchreturns 200.Built and reviewed task-by-task plus a whole-branch review; the one Important finding (unbounded fetch) was fixed in
627725e.