Add error display if annotation fails - #269
Open
muffinista wants to merge 5 commits into
Open
Conversation
toote
requested changes
Aug 19, 2025
toote
left a comment
toote
left a comment
Contributor
There was a problem hiding this comment.
Very interesting use case! If you add the options to the documentation in README.md and maybe add one test of the feature we would be more than happy to merge it!
|
@muffinista did you still want us to consider merging this PR? If so, can you respond to the feedback above? |
Author
|
Yes, sorry, I will deal with this ASAP |
muffinista
force-pushed
the
add-error-annotation
branch
from
July 22, 2026 18:19
92d017f to
20935b2
Compare
muffinista
force-pushed
the
add-error-annotation
branch
from
July 24, 2026 20:05
9fa78d1 to
81a90ef
Compare
Author
|
@omehegan ok I've added a couple of tests and some docs. If there's anything else you'd like just let me know. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This is some code I've been running in CI for quite some time, where if junit-annotate fails to generate output because of the number of annotations, we have the option of displaying that as a failure. We have a large suite of tests and this helps deal with builds that contain an error or some sort of issue so significant that the number of annotations needed to report the errors is more than junit can actually handle, causing the annotation to fail silently.