add file-based env variables for LibreTranslate and Stalwart Impersonation & handle file-based vars from JSON configs in ConfigManager - #897
Open
Cameo007 wants to merge 2 commits into
Open
Conversation
Cameo007
force-pushed
the
main
branch
3 times, most recently
from
August 23, 2026 20:24
b0a6f75 to
b9700eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think the missing file-based env vars are clear.
For ConfigManager however I noticed that Bulwark complains about
SESSION_SECRETnot being set when logging in as admin when usingsessionSecretFileinconfig.json. The thing is, it doesn’t recognize this as variant ofsessionSecretwhich this PR fixes.I didn’t test LibreTranslate and Stalwart Impersonation.
Changes
fileKeyfield onCONFIG_ENV_MAPgetandgetAllWithSourcesnow also try usingfileKeyRelated issues
Closes #
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / demo
Notes for reviewers