Skip to content

fix: added missing translation keys in contact-detail and email-composer, updated french translation - #920

Open
French-Asgeir wants to merge 1 commit into
bulwarkmail:mainfrom
French-Asgeir:feature/missing-translation-keys
Open

fix: added missing translation keys in contact-detail and email-composer, updated french translation#920
French-Asgeir wants to merge 1 commit into
bulwarkmail:mainfrom
French-Asgeir:feature/missing-translation-keys

Conversation

@French-Asgeir

Copy link
Copy Markdown
Contributor

Summary

This PR add a few missing translation key that prevented translation of some Ui element in mail composer and contact detail layouts. It also add a few missing translation for french locale.

Changes

  • Implemented translation resolution to "Cc" and and "Bcc" in mail composer
  • Implemented translation resolution to email fields in contact detail view layout
  • Implemented translation resolution to phone fields in contact detail view layout
  • Added missing translation key for phone numbers type in contact detail
  • Added a few french translation across the board

Related issues

None

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor / code quality improvement
  • Chore / dependency update / CI change

Checklist

  • I have read the Contributing Guide
  • My code follows the project's code style and conventions
  • I have run npm run typecheck && npm run lint and there are no errors
  • The build passes (npm run build)
  • I have tested my changes locally
  • I have added or updated documentation if needed
  • I have updated translations (locales/) if my changes affect user-facing text
  • I have included screenshots or a screen recording for UI changes

Screenshots / demo

Before (Contact detail):
image

After (Contact detail) :
image

Before (Mail composer) :
image

After (Mail composer) :
image

Notes for reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant