fix(email): refetch body value when JMAP truncates the displayed part - #928
Open
hildebrandttk wants to merge 1 commit into
Open
fix(email): refetch body value when JMAP truncates the displayed part#928hildebrandttk wants to merge 1 commit into
hildebrandttk wants to merge 1 commit into
Conversation
Large HTML emails (e.g. image-only reports with a data:image src cut mid-tag by the 256 KB body cap) rendered completely blank because Email.bodyValues[partId].isTruncated was declared but never acted on. On truncation, issue one follow-up Email/get with a much larger cap for the parts actually shown, batched across a thread instead of one refetch per message. Closes bulwarkmail#884
hildebrandttk
force-pushed
the
fix/truncated-body-blank-render
branch
from
September 2, 2026 20:09
7b62507 to
2cf7427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large HTML emails (e.g. image-only reports with a data:image src cut mid-tag by the 256 KB body cap) rendered completely blank because Email.bodyValues[partId].isTruncated was declared but never acted on. On truncation, issue one follow-up Email/get with a much larger cap for the parts actually shown, batched across a thread instead of one refetch per message.
Changes
Related issues
Closes #884
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / demo
Notes for reviewers