fix: add translations for plugin fetched from marketplace - #939
Open
paulhenry46 wants to merge 1 commit into
Open
fix: add translations for plugin fetched from marketplace#939paulhenry46 wants to merge 1 commit into
paulhenry46 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly added manifest.locales validation accepts arrays as “object”, which can store an invalid locales shape and still break translations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Populates installed marketplace plugins’ ServerPlugin metadata with locales from manifest.json, so sandbox/plugin i18n can resolve translation keys instead of falling back to the key string.
Changes:
- Adds
manifest.localesinto the constructedServerPluginobject during marketplace install/update.
File summaries
| File | Description |
|---|---|
| app/api/admin/marketplace/route.ts | Includes manifest.locales when constructing the ServerPlugin saved from a marketplace bundle. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+368
to
+370
| ...(manifest.locales && typeof manifest.locales === 'object' | ||
| ? { locales: manifest.locales as ServerPlugin['locales'] } | ||
| : {}), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix paulhenry46/pgp-plugin#28 . Indeed, when plugins are imported from marketplace, ServerPlugin object is not populated with locales. As a result, the plugin use the translation key as fallback.
Changes
Related issues
Closes #
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / demo
Notes for reviewers