filter-settings.tsx: Fix: Re-parse raw Sieve editor saves instead of forcing opaque mode - #965
Open
edmundlod wants to merge 2 commits into
Open
filter-settings.tsx: Fix: Re-parse raw Sieve editor saves instead of forcing opaque mode#965edmundlod wants to merge 2 commits into
edmundlod wants to merge 2 commits into
Conversation
Saving a script from the raw Sieve editor unconditionally set isOpaque: true, even when the pasted/edited script still round-trips cleanly into structured rules (e.g. a script reformatted outside Bulwark but otherwise compatible with the metadata format). This permanently locked the filter UI into raw-only editing on every raw save, regardless of content. Re-parse with parseScript(), matching what fetchFilters() already does on load, so a still-parseable script returns straight to the visual builder. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AB2CxEWNQRb842X3kuz4a
Saving a script from the raw Sieve editor unconditionally sets , even when the pasted/edited script still validates. This permanently locked the filter UI into raw-only editing on every raw save. Re-parse with , matching what already does on load, so a still-parseable script returns straight to the visual builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a script from the raw Sieve editor unconditionally sets
isOpaque: true, even when the pasted/edited script still validates.This permanently locked the filter UI into raw-only editing on every raw save. Re-parse with
parseScript(), matching whatfetchFilters()already does on load, so a still-parseable script returns straight to the visual builder.