fix: rsvp controls - #967
Open
wrycu wants to merge 1 commit into
Open
Conversation
* adds "canRSVP" in addition to the existing "getEventEditability" * wires calendar to leverage "canRSVP" before editability checks * adds tests for RSVP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
canRSVPas a concept independent of event/calendar edit-ability (since you can typically edit your own calendar). Updates existing calls to leveragecanRSVPwhere appropriate while retaining existing functionality (which was a bit of a pain). Updates the rendering to leverage RSVP controls prior to edit-ability checks, and adds tests for this going forward.Changes
canUserRSVP()to/lib/calendar-editability.tsto determine if a user can RSVPRelated issues
Closes #937
Type of change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / demo
N/A
Notes for reviewers
Existing integration tests in Docker do not check for this functionality (which is probably why it was able to happen). I did not add tests there.