v1.0.34 - #91
Merged
Merged
Conversation
Add configurable business tracing profile
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideIntroduces a global tracing detail level (Business vs Verbose) that controls which spans are produced and exported, wires it into ASP.NET Core telemetry options, filters out pipeline-detail spans in Business mode, suppresses infrastructure diagnostic spans unless Verbose, and adds tests/docs for the behavior. Sequence diagram for telemetry initialization and diagnostic span filteringsequenceDiagram
participant AppConfiguration
participant AddAetherTelemetry
participant AetherTracingRuntime
participant TracerProviderBuilder as TracerProvider
participant BusinessSpanFilterProcessor as BusinessFilter
participant InfrastructureActivitySource as InfraSource
participant DistributedLockService as LockService
AppConfiguration->>AddAetherTelemetry: AddAetherTelemetry(services, configuration)
AddAetherTelemetry->>AetherTracingRuntime: Configure(opts.Tracing.DetailLevel)
alt DetailLevel == Business
AddAetherTelemetry->>TracerProvider: AddProcessor(BusinessSpanFilterProcessor)
else DetailLevel == Verbose
AddAetherTelemetry-->>TracerProvider: AddEntityFrameworkCoreInstrumentation()
end
LockService->>InfraSource: StartDiagnosticActivity("DistributedLock.Release", ActivityKind.Client, Activity.Current.Context)
InfraSource->>AetherTracingRuntime: IsVerbose
alt IsVerbose == true
InfraSource-->>LockService: Activity instance
else IsVerbose == false
InfraSource-->>LockService: null (no diagnostic span)
end
LockService-->>BusinessFilter: OnEnd(Activity) when span completes
BusinessFilter->>BusinessFilter: activity.DisplayName.StartsWith("[")
alt Business profile and pipeline detail
BusinessFilter->>BusinessFilter: activity.ActivityTraceFlags &= ~ActivityTraceFlags.Recorded
else Keep business span
BusinessFilter-->>LockService: span exported normally
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 41 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The global AetherTracingRuntime.DetailLevel is mutated in multiple tests, which can cause flaky results when xUnit runs tests in parallel; consider disabling parallelization for these test classes/assembly or isolating the runtime configuration behind a test-only lock or helper.
- The Dapr-specific HTTP filtering and enrichment logic in ShouldTraceHttpRequest/IsDaprDiagnosticRequest/EnrichHttpClientActivity uses many hard-coded path segments and rules; consider centralising these constants or extracting a dedicated helper to make future Dapr API changes easier to maintain and reason about.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The global AetherTracingRuntime.DetailLevel is mutated in multiple tests, which can cause flaky results when xUnit runs tests in parallel; consider disabling parallelization for these test classes/assembly or isolating the runtime configuration behind a test-only lock or helper.
- The Dapr-specific HTTP filtering and enrichment logic in ShouldTraceHttpRequest/IsDaprDiagnosticRequest/EnrichHttpClientActivity uses many hard-coded path segments and rules; consider centralising these constants or extracting a dedicated helper to make future Dapr API changes easier to maintain and reason about.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce configurable tracing detail levels with business-focused default and align infrastructure diagnostics, HTTP client instrumentation, and aspects with the global tracing profile.
Enhancements:
Documentation:
Tests: