1.0.35 - #93
Merged
Merged
Conversation
Header enrich keys were built from hard-coded "RequestHeader." / "ResponseHeader." literals, so consumers could not control the resulting field name. Log backends that cannot store dots in flat field names (OpenObserve, Elasticsearch) lowercase the key and replace '.' with '_' on ingest, so an enricher configured for the header `act_sub` is queried as `requestheader_act_sub` — the prefix is baked into the field name with no way to opt out. - LoggingEnricherOptions: new RequestHeaderKeyPrefix / ResponseHeaderKeyPrefix (defaults "RequestHeader." / "ResponseHeader.", so existing behaviour is unchanged). Setting a prefix to "" emits the bare normalized header name. - New internal HeaderEnrichmentKeys centralizes key construction and header normalization; EnricherLogProcessor and HttpBodyLoggingMiddleware both use it instead of duplicating the literals and the normalize expression, so the two paths can no longer drift apart. - docs/telemetry: documented the new options, the backend field-name normalization that motivates them, and the collision caveat when both prefixes are given the same value. Only BBT.Aether.AspNetCore is affected. No behavioural change with default configuration.
…-header-prefix feat(telemetry): make enricher header key prefix configurable
Reviewer's GuideAdds configurable prefixes for HTTP header enrichment keys and centralizes header key normalization/creation so logging enricher and HTTP body middleware stay consistent and work better with backends that dislike dots in field names. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Make HTTP header log enrichment key generation configurable and consistent across telemetry components.
New Features:
Enhancements: