Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background-job span gating, deferred arm handle, and jittered poll pacing #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Background-job span gating, deferred arm handle, and jittered poll pacing #96
Changes from all commits
2490d40fe0100baf34d31File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 67 in framework/src/BBT.Aether.Core/BBT/Aether/BackgroundJob/IBackgroundJobService.cs
Method has 10 parameters, which is greater than the 7 authorized.
Check warning on line 132 in framework/src/BBT.Aether.Core/BBT/Aether/BackgroundJob/IBackgroundJobService.cs
Method has 9 parameters, which is greater than the 7 authorized.
Check warning on line 35 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Constructor has 9 parameters, which is greater than the 7 authorized.
Check failure on line 109 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
Check warning on line 120 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Method has 11 parameters, which is greater than the 7 authorized.
Check warning on line 128 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Use a comparison to 'default(TPayload)' instead or add a constraint to 'TPayload' so that it can't be a value type.
Check warning on line 148 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 193 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Complete the task associated to this 'TODO' comment.
Check warning on line 218 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 224 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Await BeginAsync instead.
Check warning on line 231 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Either log this exception and handle it, or rethrow it with some contextual information.
Check warning on line 245 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 282 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Await BeginAsync instead.
Check warning on line 324 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 342 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 348 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Await BeginAsync instead.
Check warning on line 358 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 361 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Either log this exception and handle it, or rethrow it with some contextual information.
Check warning on line 417 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Await BeginAsync instead.
Check warning on line 491 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 508 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 514 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Await BeginAsync instead.
Check warning on line 539 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 543 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/BackgroundJobService.cs
Either log this exception and handle it, or rethrow it with some contextual information.
Check warning on line 92 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 101 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Logging in a catch clause should pass the caught exception as a parameter.
Check warning on line 102 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Define a constant instead of using this literal 'job.status' 6 times.
Check warning on line 105 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Await BeginAsync instead.
Check warning on line 147 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Await BeginAsync instead.
Check warning on line 181 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Check warning on line 207 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Await BeginAsync instead.
Check warning on line 251 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/JobDispatcher.cs
Await BeginAsync instead.
Check warning on line 33 in framework/src/BBT.Aether.Infrastructure/BBT/Aether/BackgroundJob/Processing/BackgroundJobArmingHostedService.cs
Evaluation of this argument may be expensive and unnecessary if logging is disabled
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.