Skip to content

Integration tests vnext - #17

Merged
yilmaztayfun merged 24 commits into
masterfrom
integration-tests-vnext
May 12, 2026
Merged

Integration tests vnext#17
yilmaztayfun merged 24 commits into
masterfrom
integration-tests-vnext

Conversation

@EreenKara

Copy link
Copy Markdown
Contributor

No description provided.

…data enrichment (derived from on-entry task results) into the state body. An extra test was also added for another state referenced under the exit transition’s onAvailable field
…cript task and 5th task type is considered as human task type
…nd scripts were the ones putting values there. That produced a lot of false positives—we were mainly checking that scripts ran, not that the tasks themselves behaved correctly. Now many tasks are actually tested.
…er) had been missing. For “condition”, supplying a rule was enough — there are already transitions that use rules. Nothing timer-related existed, so a transition that uses a timer was added.
… test. script base test logic added to docs.
…ectly and schema data test renamed as schema-validation test. schema-validation tests are completed.
…rors on tests, probably caused by wrong workflow definition.
@EreenKara
EreenKara requested review from a team May 12, 2026 11:15

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 20000 lines

@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 260 files, which is 110 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c41d409-f034-4d20-902f-1ac49f261a0d

📥 Commits

Reviewing files that changed from the base of the PR and between 25c6280 and 3a0a903.

📒 Files selected for processing (260)
  • .cursor/skills/vnext-features/SKILL.md
  • api-tests/collection-object-test/collection-object-test-workflow.http
  • api-tests/collection-object-test/postman-collection-object-test.json
  • api-tests/error-boundary/postman-error-boundary.json
  • api-tests/extended-tasks/extended-tasks-test-workflow.http
  • api-tests/extended-tasks/postman-extended-tasks.json
  • api-tests/flow-types/flow-types-test.http
  • api-tests/instance-management/instance-management-test-workflow.http
  • api-tests/instance-management/postman-instance-management.json
  • api-tests/lifecycle-transitions/lifecycle-transitions-test-workflow.http
  • api-tests/lifecycle-transitions/postman-lifecycle-transitions.json
  • api-tests/schema-data/postman-schema-data.json
  • api-tests/schema-data/schema-data-test-workflow.http
  • api-tests/schema-validation/postman-schema-validation.json
  • api-tests/schema-validation/schema-validation-test-workflow.http
  • api-tests/smoke-runtime-check/postman-smoke-runtime-check.json
  • api-tests/subflow-orchestration/subflow-orchestration.http
  • api-tests/task-execution/postman-task-execution-collection.json
  • api-tests/task-execution/task-execution-test-workflow.http
  • api-tests/task-execution/task-execution.http
  • api-tests/version-consistency/postman-version-consistency.json
  • api-tests/version-consistency/version-consistency-test.http
  • api-tests/view-function-extension/postman-view-function-extension.json
  • api-tests/view-function-extension/view-function-extension-test-workflow.http
  • core.link.json
  • core/Extensions/subflow-test/child-data-extension.json
  • core/Extensions/subflow-test/grandchild-data-extension.json
  • core/Extensions/subflow-test/parent-data-extension.json
  • core/Extensions/subflow-test/src/ChildDataExtensionMapping.csx
  • core/Extensions/subflow-test/src/GrandchildDataExtensionMapping.csx
  • core/Extensions/subflow-test/src/ParentDataExtensionMapping.csx
  • core/Extensions/view-function-extension/global-extension.json
  • core/Extensions/view-function-extension/requested-extension.json
  • core/Extensions/view-function-extension/src/VfeDefinedFlowAndRequestedExtensionMapping.csx
  • core/Extensions/view-function-extension/src/VfeDefinedFlowsExtensionMapping.csx
  • core/Extensions/view-function-extension/src/VfeGlobalAndRequestedExtensionMapping.csx
  • core/Extensions/view-function-extension/src/VfeGlobalExtensionMapping.csx
  • core/Extensions/view-function-extension/vfe-defined-flow-and-requested-extension.json
  • core/Extensions/view-function-extension/vfe-defined-flows-extension.json
  • core/Extensions/view-function-extension/vfe-global-and-requested-extension.json
  • core/Extensions/view-function-extension/vfe-global-extension.json
  • core/Functions/view-function-extension/multi-task-function.json
  • core/Functions/view-function-extension/single-task-function.json
  • core/Functions/view-function-extension/src/FunctionMultiTask1Mapping.csx
  • core/Functions/view-function-extension/src/FunctionMultiTask2Mapping.csx
  • core/Functions/view-function-extension/src/FunctionOutputMapping.csx
  • core/Functions/view-function-extension/src/VfeDomainFunctionMapping.csx
  • core/Functions/view-function-extension/src/VfeWorkflowFunctionMapping.csx
  • core/Functions/view-function-extension/vfe-domain-function.json
  • core/Functions/view-function-extension/vfe-multi-task-function.json
  • core/Functions/view-function-extension/vfe-single-task-function.json
  • core/Functions/view-function-extension/vfe-workflow-function.json
  • core/Schemas/account-opening/account-details-input.json
  • core/Schemas/account-opening/account-type-selection.json
  • core/Schemas/schema-validation/schema-validation-cancel.json
  • core/Schemas/schema-validation/schema-validation-confirm-transition.json
  • core/Schemas/schema-validation/schema-validation-exit.json
  • core/Schemas/schema-validation/schema-validation-master.json
  • core/Schemas/schema-validation/schema-validation-start.json
  • core/Schemas/schema-validation/schema-validation-update-data.json
  • core/Tasks/collection-object-test/collection-object-script-task.json
  • core/Tasks/extended-tasks/dapr-binding-task.json
  • core/Tasks/extended-tasks/dapr-pubsub-task.json
  • core/Tasks/extended-tasks/human-task.json
  • core/Tasks/schema-validation/schema-validation-script-task.json
  • core/Tasks/subflow-test/start-busy-subprocess-task.json
  • core/Tasks/subflow-test/trigger-busy-completion-task.json
  • core/Tasks/task-execution/extended-tasks-test-workflow/dapr-http-task.json
  • core/Tasks/task-execution/extended-tasks-test-workflow/dapr-pubsub-task.json
  • core/Tasks/task-execution/extended-tasks-test-workflow/dapr-service-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/get-instance-data-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/get-instances-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/http-process-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/notification-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/start-flow-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/subprocess-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/task-exec-script-task.json
  • core/Tasks/task-execution/task-execution-test-workflow/trigger-transition-task.json
  • core/Tasks/view-function-extension/vfe-script-task-2.json
  • core/Views/account-opening/account-confirmation-view.json
  • core/Views/account-opening/account-creation-view.json
  • core/Views/account-opening/account-details-input-view.json
  • core/Views/account-opening/account-details-submit-confirmation-view.json
  • core/Views/account-opening/account-opening-success-view.json
  • core/Views/account-opening/account-type-selection-confirmation-view.json
  • core/Views/account-opening/account-type-selection-view.json
  • core/Views/account-opening/final-confirmation-popup-view.json
  • core/Views/account-opening/policy-validation-view.json
  • core/Views/subflow-test/child-workflow-view.json
  • core/Views/subflow-test/grandchild-workflow-view.json
  • core/Views/subflow-test/parent-workflow-view.json
  • core/Views/view-function-extension/deeplink-view.json
  • core/Views/view-function-extension/html-view.json
  • core/Views/view-function-extension/http-view.json
  • core/Views/view-function-extension/json-view.json
  • core/Views/view-function-extension/markdown-view.json
  • core/Views/view-function-extension/urn-view.json
  • core/Workflows/account-opening/account-opening-workflow.json
  • core/Workflows/account-opening/src/TriggerScheduledPaymentsMapping.csx
  • core/Workflows/collection-object-test/.meta/collection-object-test-workflow.diagram.json
  • core/Workflows/collection-object-test/collection-object-test-workflow.json
  • core/Workflows/collection-object-test/src/CreateAndSetMapping.csx
  • core/Workflows/collection-object-test/src/GetListAndAsListMapping.csx
  • core/Workflows/collection-object-test/src/InitCollectionTestMapping.csx
  • core/Workflows/collection-object-test/src/ListAddRemoveMapping.csx
  • core/Workflows/collection-object-test/src/ListFilterCountAnyMapping.csx
  • core/Workflows/collection-object-test/src/ListFirstLastMapping.csx
  • core/Workflows/collection-object-test/src/ListSelectMapping.csx
  • core/Workflows/collection-object-test/src/RemovePropertyToDictionaryMapping.csx
  • core/Workflows/error-boundary/.meta/error-boundary-test-workflow.diagram.json
  • core/Workflows/error-boundary/error-boundary-test-workflow.json
  • core/Workflows/error-boundary/src/ErrorHttpMapping.csx
  • core/Workflows/error-boundary/src/IgnoreErrorMapping.csx
  • core/Workflows/error-boundary/src/LogOnlyMapping.csx
  • core/Workflows/error-boundary/src/NotifyMapping.csx
  • core/Workflows/error-boundary/src/PriorityConfirmMapping.csx
  • core/Workflows/error-boundary/src/RetryConfirmMapping.csx
  • core/Workflows/error-boundary/src/RetryThrowMapping.csx
  • core/Workflows/error-boundary/src/RollbackMapping.csx
  • core/Workflows/error-boundary/src/StateLevelConfirmMapping.csx
  • core/Workflows/error-boundary/src/ThrowErrorMapping.csx
  • core/Workflows/extended-tasks/extended-tasks-test-workflow.json
  • core/Workflows/extended-tasks/src/DaprBindingMapping.csx
  • core/Workflows/extended-tasks/src/DaprPubSubMapping.csx
  • core/Workflows/extended-tasks/src/GetInstancesMapping.csx
  • core/Workflows/extended-tasks/src/HumanTaskMapping.csx
  • core/Workflows/extended-tasks/src/NotificationMapping.csx
  • core/Workflows/extended-tasks/src/SubProcessMapping.csx
  • core/Workflows/extended-tasks/src/TriggerTransitionMapping.csx
  • core/Workflows/flow-types/.meta/core-flow-test.diagram.json
  • core/Workflows/flow-types/.meta/flow-flow-test.diagram.json
  • core/Workflows/flow-types/.meta/subflow-flow-test.diagram.json
  • core/Workflows/flow-types/.meta/subprocess-flow-test.diagram.json
  • core/Workflows/flow-types/core-flow-test.json
  • core/Workflows/flow-types/flow-flow-test.json
  • core/Workflows/flow-types/src/FlowInitMapping.csx
  • core/Workflows/flow-types/src/SubFlowInitMapping.csx
  • core/Workflows/flow-types/subflow-flow-test.json
  • core/Workflows/flow-types/subprocess-flow-test.json
  • core/Workflows/instance-management/.meta/instance-management-test-workflow.diagram.json
  • core/Workflows/instance-management/instance-management-test-workflow.json
  • core/Workflows/lifecycle-transitions/.meta/lifecycle-transitions-test-workflow.diagram.json
  • core/Workflows/lifecycle-transitions/lifecycle-transitions-test-workflow.json
  • core/Workflows/lifecycle-transitions/src/AlwaysTrueRule.csx
  • core/Workflows/lifecycle-transitions/src/DefaultAutoFallbackRule.csx
  • core/Workflows/lifecycle-transitions/src/ProcessEntryMapping.csx
  • core/Workflows/lifecycle-transitions/src/ShortTimerMapping.csx
  • core/Workflows/lifecycle-transitions/src/TestPathDefaultFallbackRule.b64.txt
  • core/Workflows/payments/payment-notification-subflow.json
  • core/Workflows/payments/payment-process.json
  • core/Workflows/payments/scheduled-payments-workflow.json
  • core/Workflows/payments/src/SendPaymentNotificationSmsMapping.csx
  • core/Workflows/payments/src/SendPaymentPushNotificationMapping.csx
  • core/Workflows/schema-data/schema-data-test-workflow.json
  • core/Workflows/schema-validation/.meta/schema-validation-subflow-child.diagram.json
  • core/Workflows/schema-validation/.meta/schema-validation-test-workflow.diagram.json
  • core/Workflows/schema-validation/schema-validation-subflow-child.json
  • core/Workflows/schema-validation/schema-validation-test-workflow.json
  • core/Workflows/schema-validation/src/ConfirmExecutionMapping.csx
  • core/Workflows/schema-validation/src/SchemaInitMapping.csx
  • core/Workflows/schema-validation/src/SubflowPassthroughMapping.csx
  • core/Workflows/smoke-runtime-check/smoke-runtime-check-workflow.json
  • core/Workflows/subflow-orchestration/.meta/subflow-orchestration-child.diagram.json
  • core/Workflows/subflow-orchestration/.meta/subflow-orchestration-grandchild.diagram.json
  • core/Workflows/subflow-orchestration/.meta/subflow-orchestration-parent.diagram.json
  • core/Workflows/subflow-orchestration/src/ChildSharedMarkMapping.csx
  • core/Workflows/subflow-orchestration/src/ParentSharedCommonTransitionMapping.csx
  • core/Workflows/subflow-orchestration/src/UpdateParentDataMapping.csx
  • core/Workflows/subflow-orchestration/subflow-orchestration-child.json
  • core/Workflows/subflow-orchestration/subflow-orchestration-grandchild.json
  • core/Workflows/subflow-orchestration/subflow-orchestration-parent.json
  • core/Workflows/subflow-test/.meta/busy-subprocess-workflow.diagram.json
  • core/Workflows/subflow-test/.meta/subflow-view-test-child.diagram.json
  • core/Workflows/subflow-test/.meta/subflow-view-test-grandchild.diagram.json
  • core/Workflows/subflow-test/.meta/subflow-view-test-parent.diagram.json
  • core/Workflows/subflow-test/busy-subprocess-workflow.json
  • core/Workflows/subflow-test/src/AlwaysTrueRule.csx
  • core/Workflows/subflow-test/src/BusySubprocessStartMapping.csx
  • core/Workflows/subflow-test/src/ChildCompleteMapping.csx
  • core/Workflows/subflow-test/src/ChildSharedUpdateMapping.csx
  • core/Workflows/subflow-test/src/ChildStartMapping.csx
  • core/Workflows/subflow-test/src/ChildToGrandchildSubFlowMapping.csx
  • core/Workflows/subflow-test/src/GrandchildCompleteMapping.csx
  • core/Workflows/subflow-test/src/GrandchildStartMapping.csx
  • core/Workflows/subflow-test/src/ParentCompleteMapping.csx
  • core/Workflows/subflow-test/src/ParentInitialGetInstanceDataMapping.csx
  • core/Workflows/subflow-test/src/ParentSharedUpdateMapping.csx
  • core/Workflows/subflow-test/src/ParentStartMapping.csx
  • core/Workflows/subflow-test/src/StartBusySubprocessMapping.csx
  • core/Workflows/subflow-test/src/SubFlowMapping.csx
  • core/Workflows/subflow-test/src/TriggerParentBusyCompletionMapping.csx
  • core/Workflows/subflow-test/subflow-view-test-child.json
  • core/Workflows/subflow-test/subflow-view-test-grandchild.json
  • core/Workflows/subflow-test/subflow-view-test-parent.json
  • core/Workflows/task-execution/.meta/extended-tasks-test-workflow.diagram.json
  • core/Workflows/task-execution/.meta/task-execution-test-workflow.diagram.json
  • core/Workflows/task-execution/.meta/task-target-workflow.diagram.json
  • core/Workflows/task-execution/extended-tasks-test-workflow.json
  • core/Workflows/task-execution/src/AlwaysTrueRule.csx
  • core/Workflows/task-execution/src/CrossWorkflowMapping.csx
  • core/Workflows/task-execution/src/extended-tasks-test-workflow/DaprHttpMapping.csx
  • core/Workflows/task-execution/src/extended-tasks-test-workflow/DaprPubSubMapping.csx
  • core/Workflows/task-execution/src/extended-tasks-test-workflow/DaprServiceMapping.csx
  • core/Workflows/task-execution/src/extended-tasks-test-workflow/InitExtendedTaskMapping.csx
  • core/Workflows/task-execution/src/shared/AlwaysTrueRule.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/GetInstanceDataMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/GetInstancesMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/HttpProcessMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/InitTaskTestMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/ScriptProcessMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/StartFlowMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/SubProcessMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/TimerScheduleMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/TimerStartMapping.csx
  • core/Workflows/task-execution/src/task-execution-test-workflow/TriggerTransitionMapping.csx
  • core/Workflows/task-execution/task-execution-test-workflow.json
  • core/Workflows/task-execution/task-target-workflow.json
  • core/Workflows/version-consistency/.meta/version-consistency-test-workflow-v2.diagram.json
  • core/Workflows/version-consistency/.meta/version-consistency-test-workflow.diagram.json
  • core/Workflows/version-consistency/version-consistency-test-workflow-v2.json
  • core/Workflows/version-consistency/version-consistency-test-workflow.json
  • core/Workflows/view-function-extension/.meta/view-function-extension-test-workflow.diagram.json
  • core/Workflows/view-function-extension/view-function-extension-test-workflow.json
  • doc/integration-test-documentation.md
  • docs/integration-test-documentation.md
  • index.js
  • postman/vNext Example Runtime.postman_collection.json
  • tests/Core/Helpers/InstanceListJson.cs
  • tests/Core/Helpers/JsonElementAssertions.cs
  • tests/Core/Helpers/StateFunctionJson.cs
  • tests/Core/Helpers/TestDataBuilder.cs
  • tests/Core/Helpers/WorkflowInstanceTestHelper.cs
  • tests/Core/Helpers/WorkflowTestHttpHeaders.cs
  • tests/Core/Tests/collection-object-test/CollectionObjectInstanceDataAssertions.cs
  • tests/Core/Tests/collection-object-test/CollectionObjectTestWorkflowTests.cs
  • tests/Core/Tests/error-boundary-test-workflow/ErrorBoundaryInstanceDataAssertions.cs
  • tests/Core/Tests/error-boundary-test-workflow/ErrorBoundaryTestWorkflowTests.cs
  • tests/Core/Tests/flow-types/FlowTypesTests.cs
  • tests/Core/Tests/instance-management-test-workflow/InstanceManagementInstanceDataAssertions.cs
  • tests/Core/Tests/instance-management-test-workflow/InstanceManagementScenarioActions.cs
  • tests/Core/Tests/instance-management-test-workflow/InstanceManagementTestWorkflowTests.cs
  • tests/Core/Tests/lifecycle-transitions-test-workflow/LifecyclePassPathInstanceDataAssertions.cs
  • tests/Core/Tests/lifecycle-transitions-test-workflow/LifecycleTransitionsTestWorkflowTests.cs
  • tests/Core/Tests/schema-validation-test-workflow/SchemaValidationInstanceDataAssertions.cs
  • tests/Core/Tests/schema-validation-test-workflow/SchemaValidationScenarioActions.cs
  • tests/Core/Tests/schema-validation-test-workflow/SchemaValidationTestWorkflowTests.cs
  • tests/Core/Tests/subflow-orchestration-test-workflow/SubflowOrchestrationInstanceDataAssertions.cs
  • tests/Core/Tests/subflow-orchestration-test-workflow/SubflowOrchestrationScenarioActions.cs
  • tests/Core/Tests/subflow-orchestration-test-workflow/SubflowOrchestrationTestWorkflowTests.cs
  • tests/Core/Tests/task-execution-test-workflow/TaskExecutionInstanceDataAssertions.cs
  • tests/Core/Tests/task-execution-test-workflow/TaskExecutionTestWorkflowTests.cs
  • tests/Core/Tests/version-consistency-test-workflow/VersionConsistencyInstanceDataAssertions.cs
  • tests/Core/Tests/version-consistency-test-workflow/VersionConsistencyScenarioActions.cs
  • tests/Core/Tests/version-consistency-test-workflow/VersionConsistencyTestWorkflowTests.cs
  • tests/Core/Tests/view-function-extension-test-workflow/VfeExtensionAssertions.cs
  • tests/Core/Tests/view-function-extension-test-workflow/VfeFunctionAssertions.cs
  • tests/Core/Tests/view-function-extension-test-workflow/VfeScenarioActions.cs
  • tests/Core/Tests/view-function-extension-test-workflow/VfeViewAssertions.cs
  • tests/Core/Tests/view-function-extension-test-workflow/ViewFunctionExtensionTestWorkflowTests.cs
  • vnext.config.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch integration-tests-vnext

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly updates the vNext Runtime platform reference and its integration tests. It introduces a comprehensive domain knowledge skill file, refines Postman and HTTP test collections to match C# integration tests, and reorganizes various workflow components including schemas, tasks, and views. A major part of the change involves standardizing labels and descriptions to English and enhancing test coverage for core features like error boundaries, schema validation, and version consistency. I have no feedback to provide as the existing review comment was filtered out based on the instructions.

@yilmaztayfun
yilmaztayfun merged commit 8b15a91 into master May 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants