fix(magic): dispel снимает случайный снимаемый аффект (#3292)#3293
Merged
Conversation
CastUnaffects для kDispellMagic брал случайный аффект из всего списка victim->affected. Если жребий падал на неснимаемый (charm, quest, patronage, solobonus, eviless, kCharmed-битвектор) -- CheckNodispel возвращал true и заклинание фейлилось с NOEFFECT, хотя рядом в списке могли висеть вполне снимаемые аффекты. Теперь сначала считаем снимаемые (CheckNodispel == false), и если их ноль -- NOEFFECT; иначе выбираем случайный именно среди них. Два прохода по списку affected (он короткий), без лишних аллокаций. Closes #3292 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CastUnaffectsдляkDispellMagic(src/gameplay/magic/magic.cpp:3306) выбирал случайный аффект из всегоvictim->affected, а потом проверялCheckNodispel. Если жребий падал на неснимаемый (charm / quest / patronage / solobonus / eviless / битвектор kCharmed) — заклинание сразу фейлилось сNOEFFECT, хотя в списке могли быть снимаемые аффекты.Теперь:
CheckNodispel(aff) == false);NOEFFECT;number(1, dispellable)и снимаем именно его.Два прохода по
affected(список короткий), без аллокаций и новых include.Closes #3292
Test plan
-Dyaml=builtinсобираетсяmeson test -C build_yaml2— зелёные🤖 Generated with Claude Code