Skip to content

ci: skip the Codex review job for Dependabot PRs#127

Merged
heymrbox merged 2 commits into
mainfrom
ci-codex-skip-dependabot
Jun 30, 2026
Merged

ci: skip the Codex review job for Dependabot PRs#127
heymrbox merged 2 commits into
mainfrom
ci-codex-skip-dependabot

Conversation

@EdHasNoLife

Copy link
Copy Markdown
Collaborator

Dependabot PRs run the Codex review job (they push same-repo branches, so the fork guard misses them), but pull_request withholds secrets from Dependabot → the job fails with no OPENAI_API_KEY. Six open Dependabot PRs (#87, #88, #111, #117, #122, #123) show a spurious Codex Review failure.

Extend the job's if: guard to also skip dependabot[bot], mirroring the existing fork skip (same "no secret access" rationale). No behavior change for human/same-repo PRs.

Dependabot pushes to a same-repo branch, so the existing fork guard
(head.repo == repository) does not exclude it — but pull_request runs for
Dependabot are withheld repository secrets, so the Codex step fails with no
OPENAI_API_KEY and every Dependabot PR shows a spurious "Codex Review"
failure. Extend the guard to also skip github.actor == dependabot[bot],
mirroring the fork skip for the same no-secret-access reason.
@github-actions

Copy link
Copy Markdown

Codex review

Files reviewed

  • .github/workflows/
    • .github/workflows/codex-review.yml [reviewed]

Findings

Blocking

None.

Should-fix

.github/workflows/codex-review.yml:34 — The guard checks github.actor, which is the account that triggered this particular pull_request event, not necessarily the PR author. A Dependabot PR reopened by a maintainer can still run this job without secrets and reproduce the spurious failure; use github.event.pull_request.user.login != 'dependabot[bot]' for the PR identity.

Nit

None.

Per-category coverage

  1. Vendor-neutral naming: Clean
  2. Contract & spec / docs sync: Clean
  3. gRPC fail-open semantics: Clean
  4. Quality (tests / error wrapping / package placement / generated drift): findings above at: .github/workflows/codex-review.yml:34

Verdict

changes-requested

github.actor is whoever triggered the run — a maintainer who reopens a
Dependabot PR would re-run the secret-less job. pull_request.user.login is
the PR author, the stable identity for the no-secret-access skip.
@github-actions

Copy link
Copy Markdown

Codex review

Files reviewed

  • .github/workflows/
    • .github/workflows/codex-review.yml [reviewed]

Findings

Blocking

None.

Should-fix

None.

Nit

.github/workflows/codex-review.yml:9 — The workflow header comment still only says forked PRs are skipped, but the job now also skips Dependabot PRs. The nearby job comment is accurate, so this is only minor comment drift.

Per-category coverage

  1. Vendor-neutral naming: Clean
  2. Contract & spec / docs sync: Clean
  3. gRPC fail-open semantics: Clean
  4. Quality (tests / error wrapping / package placement / generated drift): findings above at: .github/workflows/codex-review.yml:9

Verdict

approve-with-nits

@heymrbox
heymrbox merged commit 425b84f into main Jun 30, 2026
13 checks passed
@EdHasNoLife
EdHasNoLife deleted the ci-codex-skip-dependabot branch June 30, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants