Merge master from upstream into main - #136
Conversation
Allow digits in Pulumi provider name (e.g auth0)
CustomResourceOptions CE
|
Hey @NatElkins, thanks for the PR! I think we might have some overlapping code regarding |
|
@NatElkins The only file in this PR looks ok to me, just a little different formatting. However, this is only the CE, in my original PR I had a few more changes to use the CE in the resources CEs. You might want to study them too. |
|
I'm leaning toward @mvsmal's implementation because it means fewer top-level custom operations that could conflict with resource argument names. But I'm going to be quite busy with work and moving for at least Q1, so I'm not sure when I'll get around to testing that change. I also understand the docs for adding your GH packages creds to paket are missing — it's pretty high priority for me to just get the packages on NuGet but Pulumi has their prefix reserved and UnoSD owns the existing packages. When I do get around to it, my packages will probably have to have a different prefix, just FYI. |
Proposed Changes
This is a branch that merged the
masterbranch from https://github.com/UnoSD/Pulumi.FSharp.Extensions to this repo.Types of changes
What types of changes does your code introduce to Pulumi.FSharp.Extensions?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.