Make ResultSet serializable so cached queries can be executed - #347
Open
andrii-pukhalevych wants to merge 2 commits into
Open
Make ResultSet serializable so cached queries can be executed#347andrii-pukhalevych wants to merge 2 commits into
andrii-pukhalevych wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Query::cache() and then executing the query always threw "Serialization of 'CurlHandle' is not allowed", which made query result caching unusable with FileEngine.
Query::all() hands the decorated ResultSet to QueryCacher::store(), and ResultSet keeps the query that produced it in $queryObject. From there the whole connection is reachable:
Add __serialize()/__unserialize() that leave the query object out.
The decorated Elastica\ResultSet is kept whole rather than flattened to documents, so getTotalHits(), getAggregations(), getSuggests(), getMaxScore(), getTotalTime() and hasTimedOut() still answer correctly after a cache round trip. Since unserialize() does not run the constructor, __unserialize() calls parent::__construct() to set up the decorated iterator.