You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a reusable agent-device/cloud-webdriver provider-runtime module for BrowserStack, AWS Device Farm, and custom Appium/WebDriver clouds. The module keeps provider-specific WebDriver session setup, capabilities, upload/release behavior, snapshot conversion, gestures, and artifact mapping out of daemon routing.
Adds a shared CloudArtifact surface with CLI and typed-client access through artifacts [provider-session-id] --provider <name> / client.sessions.artifacts(...), plus provider release payloads from close --json and disconnect --json when a runtime returns final artifacts. artifacts now also infers the active cloud provider session from the stored lease before disconnect, while historical lookup still supports BrowserStack credentials and the AWS CLI credential chain.
Hardens the user-facing artifact UX: ready provider URLs are printed directly by the explicit artifacts command, pending/unavailable results include an exact retry command, canonical built-in provider names are exported from agent-device/cloud-webdriver, and the provider undefined vs unavailable contract is documented.
Updates docs and domain vocabulary for cloud artifacts, the new cloud-webdriver subpath, sensitive provider URLs, and the provider workflow. Scope: 52 touched files, mostly the new isolated module plus focused docs and provider tests.
Integration checks passed: full unit suite with local server/process permissions, provider-backed integration progress check, Node integration smoke suite, provider integration suite, cloud WebDriver runtime scenario, BrowserStack adapter scenario, and AWS Device Farm adapter scenario.
Hardening checks from this pass passed: active-session artifacts inference after open, handled-unavailable artifact lookup behavior, plain text artifact URL output, exact retry command output, and provider adapter artifact mapping.
Live verification passed without opening new cloud device minutes: agent-device artifacts returned ready BrowserStack artifacts for an existing session (video, Appium log, device log, dashboard links) and ready AWS Device Farm artifacts for an existing remote access session (video, Appium log, device logs, automation logs, raw files). Temporary local daemon state from verification was cleaned up.
Reviewed the cloud WebDriver artifact support path.
I traced the shipped command route from CLI/typed client input through command projection, daemon lease routing, active-session lease inference, provider runtime artifact lookup, and close/disconnect release payloads. The important paths are covered by tests: active-session artifacts before release, handled-unavailable artifact lookup, provider release payloads, BrowserStack/AWS artifact mapping, CLI text/JSON output, command descriptor routing, and package exports.
Checks are green, and the PR body includes live verification for existing BrowserStack and AWS Device Farm sessions without opening new cloud minutes. I do not see remaining actionable blockers; ready for human review/merge judgment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable
agent-device/cloud-webdriverprovider-runtime module for BrowserStack, AWS Device Farm, and custom Appium/WebDriver clouds. The module keeps provider-specific WebDriver session setup, capabilities, upload/release behavior, snapshot conversion, gestures, and artifact mapping out of daemon routing.Adds a shared
CloudArtifactsurface with CLI and typed-client access throughartifacts [provider-session-id] --provider <name>/client.sessions.artifacts(...), plus provider release payloads fromclose --jsonanddisconnect --jsonwhen a runtime returns final artifacts.artifactsnow also infers the active cloud provider session from the stored lease before disconnect, while historical lookup still supports BrowserStack credentials and the AWS CLI credential chain.Hardens the user-facing artifact UX: ready provider URLs are printed directly by the explicit
artifactscommand, pending/unavailable results include an exact retry command, canonical built-in provider names are exported fromagent-device/cloud-webdriver, and the providerundefinedvsunavailablecontract is documented.Updates docs and domain vocabulary for cloud artifacts, the new
cloud-webdriversubpath, sensitive provider URLs, and the provider workflow. Scope: 52 touched files, mostly the new isolated module plus focused docs and provider tests.Validation
Static and packaging checks passed:
tsc -p tsconfig.json,oxlint . --deny-warnings, scopedoxfmt --check,rslib build, package export tests, MCP metadata sync,fallow audit --base origin/main, andgit diff --check.Focused tests passed: CLI/help plus default cloud artifact provider tests; daemon lifecycle, command registry, request handler catalog, provider runtime, CLI client commands, management output, command descriptor parity, and package exports.
Integration checks passed: full unit suite with local server/process permissions, provider-backed integration progress check, Node integration smoke suite, provider integration suite, cloud WebDriver runtime scenario, BrowserStack adapter scenario, and AWS Device Farm adapter scenario.
Hardening checks from this pass passed: active-session
artifactsinference afteropen, handled-unavailable artifact lookup behavior, plain text artifact URL output, exact retry command output, and provider adapter artifact mapping.Live verification passed without opening new cloud device minutes:
agent-device artifactsreturned ready BrowserStack artifacts for an existing session (video, Appium log, device log, dashboard links) and ready AWS Device Farm artifacts for an existing remote access session (video, Appium log, device logs, automation logs, raw files). Temporary local daemon state from verification was cleaned up.