refactor: extract snapshot/ folder — Phase 5#953
Merged
Conversation
Move the AX-snapshot processing domain out of utils/ into a dedicated
src/snapshot/ intent folder, per plans/perfect-shape.md §5.5 (utils hosts
the AX-snapshot domain among 3 subsystems).
Files moved (9): snapshot-{diff,label-signals,lines,occlusion,processing,
quality,tree,visibility} + mobile-snapshot-semantics (processes SnapshotNode,
depends on snapshot-tree). android-helper-snapshot-presentation stays in
utils/ with its android-helper-presentation/ cluster.
- git renames; imports repointed via the resolve-based codemod
(staying-utils -> ../utils/, intra-snapshot -> ./, kernel unchanged)
- no public-export/rslib impact; update fallow-baselines/health.json keys
- tests stay in their domain __tests__/ dirs, imports repointed
Behaviorless path codemod. typecheck/lint/format/build/tests green.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Reviewed against |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the AX-snapshot processing domain out of
utils/into a dedicatedsrc/snapshot/intent folder, per plans/perfect-shape.md §5.5 (utils/hosts the AX-snapshot domain among 3 buried subsystems).Files moved (9):
snapshot-diff,snapshot-label-signals,snapshot-lines,snapshot-occlusion,snapshot-processing,snapshot-quality,snapshot-tree,snapshot-visibility, andmobile-snapshot-semantics.Boundary
mobile-snapshot-semantics.ts— it processesSnapshotNodeand depends onsnapshot-tree, so it's squarely snapshot-domain.android-helper-snapshot-presentation.ts— despite the name, it's the entry point of theandroid-helper-presentation/subdir cluster (geometry/predicates/structural-noise/tree); it stays with that cluster.How
utilsdeps →../utils/, intra-snapshot →./,kernelunchanged).fallow-baselines/health.jsonkeys (incl.:high impactvariants). Tests stay in their domain__tests__/dirs with repointed imports.Safety
typecheck ✅ · oxlint ✅ · format ✅ · build ✅ · fallow audit ✅ (no issues in 57 changed files) · targeted unit tests ✅ (26 passing). Behaviorless path codemod, 56 files. Independent of the merged #950/#951.