refactor: extract client/ folder — Phase 5#960
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Move the SDK client + companion-tunnel cluster out of the src/ root into a dedicated src/client/ folder, per plans/perfect-shape.md §5.5 (~8k LOC client/remote unfoldered at src root; remote/ already extracted in #951). Files moved (9): client, client-types, client-shared, client-normalizers, client-companion-tunnel{,-contract,-worker}, client-react-devtools-companion, companion-tunnel. - git renames; 68 importers repointed via the resolve-based codemod (intra-client stays ./, staying deps recomputed) - companion-tunnel.ts keeps rslib key 'internal/companion-tunnel' so dist output stays dist/src/internal/companion-tunnel.js (public subpath byte-identical; verified by build) - update non-src importers (3 integration tests, vitest coverage include), .fallowrc.json entrypoint, fallow-baselines/health.json keys backend.ts and daemon-client*.ts are intentionally left for follow-up (daemon/client split). Behaviorless path codemod; all gates green.
thymikee
force-pushed
the
phase5-client-folder
branch
from
97b3f39 to
a8684f6
Compare
Member
Author
|
Reviewed against plans/perfect-shape.md section 5.5 and the package/build seams. This is a behaviorless client-cluster move: the nine client/companion files are preserved as renames with relative import updates, stale root imports were repointed to src/client, and the internal/companion-tunnel rslib key still emits the same public dist path. The mock path fixes cover the non-static import cases, fallow/package paths were updated, and checks are green. No blockers; marking ready-for-human. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the SDK client + companion-tunnel cluster out of the
src/root into a dedicatedsrc/client/folder, per plans/perfect-shape.md §5.5 ("~8k LOC client/remote unfoldered at src root";remote/already extracted in #951).Files moved (9):
client,client-types,client-shared,client-normalizers,client-companion-tunnel{,-contract,-worker},client-react-devtools-companion,companion-tunnel.How
./, staying deps recomputed).companion-tunnel.tskeeps its rslib keyinternal/companion-tunnel, so dist output staysdist/src/internal/companion-tunnel.jsand the public subpath is byte-identical (verified by build)..fallowrc.jsonentrypoint, andfallow-baselines/health.jsonkeys.vi.mock('../client-react-devtools-companion.ts')paths the static-import codemod doesn't see (a wrong mock path would silently load the real module) — confirmed the mocks still apply.Scope note
backend.tsanddaemon-client*.tsare intentionally left for a follow-up (thedaemon/client/split) to keep this PR a focused client-cluster move.Safety
typecheck ✅ · oxlint ✅ · format ✅ · build ✅ (public
internal/companion-tunneldist preserved) · fallow audit ✅ (no issues in 79 changed files) · targeted unit tests ✅ (client 34, the two mock-fixed tests 47). Behaviorless path codemod, 78 files.