[DPE-10738] feat(config): port PostgreSQL parameter building + resource introspection (2/6)#182
Open
marceloneppel wants to merge 2 commits into
Open
[DPE-10738] feat(config): port PostgreSQL parameter building + resource introspection (2/6)#182marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
marceloneppel
force-pushed
the
skl-01-update-config-1-peer-accessors
branch
from
July 20, 2026 13:22
22d4f17 to
10eea18
Compare
marceloneppel
force-pushed
the
skl-01-update-config-2-params
branch
from
July 20, 2026 13:22
a7ee622 to
786d9bd
Compare
marceloneppel
changed the title
2 tasks
marceloneppel
changed the title
marceloneppel
force-pushed
the
skl-01-update-config-1-peer-accessors
branch
from
July 20, 2026 19:04
10eea18 to
ee47a46
Compare
marceloneppel
force-pushed
the
skl-01-update-config-2-params
branch
from
July 20, 2026 19:04
786d9bd to
ddf2305
Compare
Base automatically changed from
skl-01-update-config-1-peer-accessors
to
16/edge
July 21, 2026 14:38
…tion Internalizes PostgreSQL parameter calculation (worker-process auto/cap rules, wal_compression, memory-limit conversion) into the library so ConfigManager owns the full config-build flow instead of stopping at a TODO. Resource discovery (cpu_cores, memory_bytes) moves onto the workload rather than a substrate-specific manager: get_available_memory already lives there, ConfigManager already holds self.workload, and K8sManager doesn't exist yet when ConfigManager is constructed in abstract_charm - so the workload is the only place both substrates can share a single no-branch call site. K8sWorkload gains required unit_name/namespace constructor args so its lightkube Pod/Node lookups can resolve "my own pod" without depending on a charm object reference, mirroring what the K8s charm does today via self.unit.name/self.model.name. lightkube becomes a real (not merely transitive) dependency via a new k8s pyproject extra, matching the version pins the K8s test charm already uses. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
force-pushed
the
skl-01-update-config-2-params
branch
from
July 21, 2026 17:46
ddf2305 to
f9a1111
Compare
marceloneppel
marked this pull request as ready for review
July 21, 2026 20:35
marceloneppel
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot and
taurus-forever
and removed request for
a team
July 21, 2026 20:35
marceloneppel
changed the title
dragomirp
reviewed
Jul 23, 2026
Comment on lines
+56
to
+57
| self.unit_name = unit_name | ||
| self.namespace = namespace |
Contributor
There was a problem hiding this comment.
Maybe we can move the methods depending on those to the state class?
dragomirp
approved these changes
Jul 23, 2026
akram09
approved these changes
Jul 23, 2026
Comment on lines
+56
to
+57
| self.unit_name = unit_name | ||
| self.namespace = namespace |
| """Returns the system available memory in bytes.""" | ||
| raise NotImplementedError | ||
|
|
||
| def _get_node_name_for_pod(self) -> str: |
Contributor
There was a problem hiding this comment.
Do you think it would make sense to move the functions that communicate with k8s to a separate manager or a separate K8s client class that is used in the managers ?
Member
Author
There was a problem hiding this comment.
I think so. Done on ef52b09. It needed some more adjustments to reach a working state.
The parameter-building port placed lightkube node/pod resource lookups on K8sWorkload and injected unit_name/namespace into its constructor. Both duplicate identity the state already holds and put K8s-API code on the workload abstraction, which reviewers flagged. Move the lookups onto K8sManager, which is already K8s-only-loaded and holds the state, sourcing pod/namespace from state.peer.unit_name and state.model_name. ConfigManager reaches the value through a new state.available_resources property backed by a per-substrate provider (the VM workload, or the K8s manager), so the call site stays substrate-agnostic and lightkube never enters the VM import graph. Behavior is unchanged: node allocatable clamped by the container limit, 403 -> DeployedWithoutTrustError. The Node lookups drop the namespace argument, which lightkube ignores for cluster-scoped resources. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
update_configbuilds PostgreSQL'sbootstrap.dcs.postgresql.parametersfrom the unit's CPU and memory, which both charms compute per substrate. This step ports the parameter builder and the substrate resource introspection it depends on.Solution
managers/config.py:_build_postgresql_parameterswith the_calculate_max_*helpers and_calculate_worker_process_config(cpu_cores).get_available_resources() -> tuple[int, int]— VM readsos.cpu_count()and available memory; K8s reads the node/pod via lightkube and raisesDeployedWithoutTrustErroron a 403ApiError.k8soptional extra (lightkube,lightkube-models) mirroring the existingvmextra, plus a regenerateduv.lock.DeployedWithoutTrustErroris raised here and caught at the charm/event layer in the charm-adoption PR (managers-raise convention). Second (code-only) PR in the update_config stack; theK8sWorkloadsignature gainsunit_name/namespace, so the one-line fixture update needed to keep the suite green rides with the code, and the new unit tests land in the stack's test PR (#188).Checklist