Skip to content

Remember connections across refreshes#817

Draft
jonathan-conder wants to merge 4 commits into
mainfrom
fix/refresh-forgets-connections
Draft

Remember connections across refreshes#817
jonathan-conder wants to merge 4 commits into
mainfrom
fix/refresh-forgets-connections

Conversation

@jonathan-conder

@jonathan-conder jonathan-conder commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

The code is now artisanal but the tests are still vibecoded.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

Procedure:

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Content:

  • Headings and titles accurately describe the content.
  • New and updated pages include correct metadata.
  • Documentation tests are added or updated where applicable (for tutorial/ and how-to/ sections).
  • Documentation follows the style guide.
  • If needed, docs/.coverage.yaml updated, coverage tags added (.. artefact).

Or:

  • I confirm the PR has no implications for documentation.

@jonathan-conder jonathan-conder self-assigned this Jun 3, 2026
@jonathan-conder

Copy link
Copy Markdown
Contributor Author

@copilot fix the linter issues within this PR (i.e. use maps.Copy)

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@copilot fix the linter issues within this PR (i.e. use maps.Copy)

Addressed in cf759c2.

@jonathan-conder

Copy link
Copy Markdown
Contributor Author

@copilot also add some test coverage while you're at it

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@copilot also add some test coverage while you're at it

Addressed in a30f2aa.

@jonathan-conder

Copy link
Copy Markdown
Contributor Author

@copilot in future please don't remove the disclaimer I deliberately put in the description...

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@copilot in future please don't remove the disclaimer I deliberately put in the description...

Understood. I apologize for removing the disclaimer from the PR description. I've ensured it's been restored and will preserve the disclaimer in future updates to the PR.

@jonathan-conder
jonathan-conder force-pushed the fix/refresh-forgets-connections branch 8 times, most recently from a77ed63 to 6028f6b Compare July 19, 2026 23:07
@dmitry-lyfar

Copy link
Copy Markdown
Collaborator

We should update this too: https://canonical-workshopubuntucom--939.com.readthedocs.build/explanation/workshops/concepts/#connections-across-refresh-and-restore

@jonathan-conder
jonathan-conder force-pushed the fix/refresh-forgets-connections branch 5 times, most recently from c307a31 to ea77c2f Compare July 20, 2026 23:57
@jonathan-conder
jonathan-conder force-pushed the fix/refresh-forgets-connections branch 3 times, most recently from 03b626f to def6e1a Compare July 21, 2026 06:17
@jonathan-conder
jonathan-conder force-pushed the fix/refresh-forgets-connections branch from def6e1a to 9a604c5 Compare July 21, 2026 23:37
@jonathan-conder
jonathan-conder force-pushed the fix/refresh-forgets-connections branch from 9a604c5 to 5d3d496 Compare July 21, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants