Skip to content

Initial support for VMs#911

Draft
jonathan-conder wants to merge 6 commits into
mainfrom
feature/vm
Draft

Initial support for VMs#911
jonathan-conder wants to merge 6 commits into
mainfrom
feature/vm

Conversation

@jonathan-conder

Copy link
Copy Markdown
Contributor

Description

(currently vibe coded for the most part, use at your own risk)

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

Procedure:

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Content:

  • Headings and titles accurately describe the content.
  • New and updated pages include correct metadata.
  • Documentation tests are added or updated where applicable (for tutorial/ and how-to/ sections).
  • Documentation follows the style guide.
  • If needed, docs/.coverage.yaml updated, coverage tags added (.. artefact).

Or:

  • I confirm the PR has no implications for documentation.

@jonathan-conder jonathan-conder self-assigned this Jul 3, 2026
@jonathan-conder
jonathan-conder force-pushed the feature/vm branch 3 times, most recently from b4bcd91 to 5129f33 Compare July 16, 2026 06:34
This is needed because VMs don't support mounting individual files. The
snap has a dedicated directory so it only mounts workshopctl, but in
local development the other binaries may be mounted as well. However,
only workshopctl will be on the PATH.

It's reasonably easy to make this change compatible with old workshops,
because they won't use workshopctl until the next refresh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant