Skip to content

chore(ci): test summary step #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
swaldmann wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore(ci): test summary step #20

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8fb2e8
ci: add Summary gate job and branch ruleset
swaldmann Aug 11, 2026
628322d
ci: remove gh_ruleset.json
swaldmann Aug 11, 2026
ca93625
ci: run full matrix only in merge_group, PRs get node 24 / latest only
swaldmann Aug 11, 2026
92e95f9
rm push
swaldmann Aug 11, 2026
cd3821e
Potential fix for pull request finding 'CodeQL / Workflow does not co…
swaldmann Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ name: CI

on:
workflow_dispatch:
push:
branches: [main]
merge_group:
pull_request:
branches: [main]

permissions:
contents: read
packages: read

jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -17,6 +20,7 @@ jobs:
matrix:
node-version: [22, 24]
cds-version: [8, 9, latest]
exclude: ${{ github.event_name == 'merge_group' && fromJSON('[]') || fromJSON('[{"node-version":22,"cds-version":8},{"node-version":22,"cds-version":9},{"node-version":22,"cds-version":"latest"},{"node-version":24,"cds-version":8},{"node-version":24,"cds-version":9}]') }}
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -82,3 +86,12 @@ jobs:
- run: cds v -i
- run: cds bind -2 joule-cap-proxy -o package.json
- run: npm run test:hybrid

summary:
if: always()
runs-on: ubuntu-latest
name: Summary
needs: [test, test-hybrid]

@Akatuoro Akatuoro Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the hybrid test result from the PR checks reused in the merge queue or does it need to run again?

@swaldmann swaldmann Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's run again. I'd prefer to move hybrid checks to merge queue only if you're okay with not having the PR checks.

steps:
- if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
run: exit 1
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Loading