[Misc] Added Workzone service to helm chart - #120
Conversation
- Add files/workzone.yaml.hbs with build-workzone-standard service instance and binding templates - Update lib/add.js: detect hasWorkzoneStandard and include workzone.yaml.hbs in combine() - Update files/approuter.yaml.hbs: add workzone-bind to consumedBTPServices and OWN_SAP_CLOUD_SERVICE env var - Update files/workloads.yaml.hbs: add workzone-bind to contentDeploy consumedBTPServices and ASYNC_UPLOAD=true env var
…ne-standard in cap-operator chart
There was a problem hiding this comment.
The PR introduces workzone-standard support but has several correctness issues: {{strippedAppName}} is an undefined Mustache variable that will render literally instead of being substituted, hasWorkzoneStandard appears to never be populated by readProject() meaning the feature will silently be skipped, and the new test case mutates the shared bookshop fixture without cleanup, risking interference with subsequent tests that compare against fixed YAML snapshots.
PR Bot Information
Version: 1.29.26
- File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
07db3be0-9659-11f1-883c-3db67b910bc0
…d; add validation for providerId length in tests
…y in workloads.yaml.hbs and update related test assertions
SummaryThe following content is AI-generated and provides a summary of the pull request: Add SAP Build Work Zone Standard Edition Support to Helm Chart (v0.20.0)New Feature✨ Adds support for SAP Build Work Zone, Standard Edition ( Changes
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR has multiple substantive bugs already flagged by prior reviewers (undefined {{strippedAppName}} in both templates, hasWorkzoneStandard never being set by readProject(), and test isolation pollution from the shared bookshop directory). The one new issue I found and commented on is a duplicate redundant assignment of project.workzoneProviderId outside its guard, which should be removed to avoid confusion. The author should address all open comments before merging.
PR Bot Information
Version: 1.29.26
- Event Trigger:
pull_request.ready_for_review - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
b36b6080-9707-11f1-9bf2-503d2084edf3
Co-authored-by: hyperspace-pr-bot[bot] <209611008+hyperspace-pr-bot[bot]@users.noreply.github.com>
|



Add SAP Build Work Zone Standard Edition(local-entry-point plan) Support to Helm Chart
New Feature
✨ Adds support for SAP Build Work Zone, Standard Edition (
build-workzone-standard) 'local-entry-point' plan to the CAP Operator Helm chart plugin (v0.20.0). When enabled, the plugin generates abuild-workzone-standardservice instance (local-entry-pointplan) and its binding, and updates the relevant workloads accordingly.Changes
files/workzone.yaml.hbs: New Mustache template defining thebuild-workzone-standardservice instance and binding, withproviderId(truncated to 20 chars) andexposureIdparameters derived from the app name.files/approuter.yaml.hbs: Added conditional inclusion of the workzone binding inconsumedBTPServicesand injects theOWN_SAP_CLOUD_SERVICEenvironment variable when Workzone Standard is enabled.files/workloads.yaml.hbs: Added conditional inclusion of the workzone binding in thecontentDeployjob'sconsumedBTPServiceswhen Workzone Standard is enabled.lib/add.js: ExtractedhasWorkzoneStandardfrom the project descriptor; computesworkzoneProviderId(app name, max 20 chars) and conditionally mergesworkzone.yaml.hbsintovalues.yamlduring thecombinestep.test/add.test.js: Added integration test verifying correct generation of the Workzone service instance, binding, approuterOWN_SAP_CLOUD_SERVICEenv var, and content deploy binding whenworkzone-standardis added.CHANGELOG.md: Added entry for version0.20.0documenting the new Workzone Standard support.package.json/package-lock.json: Bumped version from0.19.0to0.20.0.PR Bot Information
Version:
1.29.26pull_request.editedanthropic--claude-4.6-sonnet10bb64f0-96f0-11f1-9b9b-f6f21fe50925