Skip to content

[Misc] Added Workzone service to helm chart - #120

Merged
anirudhprasad-sap merged 10 commits into
mainfrom
workzone
Aug 18, 2026
Merged

[Misc] Added Workzone service to helm chart#120
anirudhprasad-sap merged 10 commits into
mainfrom
workzone

Conversation

@anirudhprasad-sap

@anirudhprasad-sap anirudhprasad-sap commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Add SAP Build Work Zone Standard Edition(local-entry-point plan) Support to Helm Chart

New Feature

✨ Adds support for SAP Build Work Zone, Standard Edition (build-workzone-standard) 'local-entry-point' plan to the CAP Operator Helm chart plugin (v0.20.0). When enabled, the plugin generates a build-workzone-standard service instance (local-entry-point plan) and its binding, and updates the relevant workloads accordingly.

Changes

  • files/workzone.yaml.hbs: New Mustache template defining the build-workzone-standard service instance and binding, with providerId (truncated to 20 chars) and exposureId parameters derived from the app name.
  • files/approuter.yaml.hbs: Added conditional inclusion of the workzone binding in consumedBTPServices and injects the OWN_SAP_CLOUD_SERVICE environment variable when Workzone Standard is enabled.
  • files/workloads.yaml.hbs: Added conditional inclusion of the workzone binding in the contentDeploy job's consumedBTPServices when Workzone Standard is enabled.
  • lib/add.js: Extracted hasWorkzoneStandard from the project descriptor; computes workzoneProviderId (app name, max 20 chars) and conditionally merges workzone.yaml.hbs into values.yaml during the combine step.
  • test/add.test.js: Added integration test verifying correct generation of the Workzone service instance, binding, approuter OWN_SAP_CLOUD_SERVICE env var, and content deploy binding when workzone-standard is added.
  • CHANGELOG.md: Added entry for version 0.20.0 documenting the new Workzone Standard support.
  • package.json / package-lock.json: Bumped version from 0.19.0 to 0.20.0.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.29.26

  • Event Trigger: pull_request.edited
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template
  • File Content Strategy: Full file content
  • Summary Prompt: Default Prompt
  • Correlation ID: 10bb64f0-96f0-11f1-9b9b-f6f21fe50925

- Add files/workzone.yaml.hbs with build-workzone-standard service instance and binding templates
- Update lib/add.js: detect hasWorkzoneStandard and include workzone.yaml.hbs in combine()
- Update files/approuter.yaml.hbs: add workzone-bind to consumedBTPServices and OWN_SAP_CLOUD_SERVICE env var
- Update files/workloads.yaml.hbs: add workzone-bind to contentDeploy consumedBTPServices and ASYNC_UPLOAD=true env var

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces workzone-standard support but has several correctness issues: {{strippedAppName}} is an undefined Mustache variable that will render literally instead of being substituted, hasWorkzoneStandard appears to never be populated by readProject() meaning the feature will silently be skipped, and the new test case mutates the shared bookshop fixture without cleanup, risking interference with subsequent tests that compare against fixed YAML snapshots.

PR Bot Information

Version: 1.29.26

  • File Content Strategy: Full file content
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 07db3be0-9659-11f1-883c-3db67b910bc0

Comment thread files/workzone.yaml.hbs Outdated
Comment thread files/approuter.yaml.hbs
Comment thread lib/add.js
Comment thread test/add.test.js
…d; add validation for providerId length in tests
…y in workloads.yaml.hbs and update related test assertions
@anirudhprasad-sap
anirudhprasad-sap marked this pull request as ready for review August 13, 2026 11:11
@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Add SAP Build Work Zone Standard Edition Support to Helm Chart (v0.20.0)

New Feature

✨ Adds support for SAP Build Work Zone, Standard Edition (workzone-standard) to the CAP Operator Helm chart plugin. When enabled, the plugin generates a build-workzone-standard service instance using the local-entry-point plan, along with its binding, and updates the relevant workloads accordingly.

Changes

  • files/workzone.yaml.hbs: New Mustache template defining the build-workzone-standard service instance and binding, with providerId (truncated to 20 chars) and exposureId parameters derived from the app name.
  • files/approuter.yaml.hbs: Added conditional inclusion of the workzone binding in consumedBTPServices and injects the OWN_SAP_CLOUD_SERVICE environment variable when Workzone Standard is enabled.
  • files/workloads.yaml.hbs: Added conditional inclusion of the workzone binding in the contentDeploy job's consumedBTPServices when Workzone Standard is enabled.
  • lib/add.js: Extracts hasWorkzoneStandard from the project descriptor, computes workzoneProviderId (app name, max 20 chars), and conditionally merges workzone.yaml.hbs into values.yaml during the combine step.
  • test/add.test.js: Added integration test verifying correct generation of the Workzone service instance, binding, approuter OWN_SAP_CLOUD_SERVICE env var, and content deploy binding when workzone-standard is added.
  • CHANGELOG.md: Added entry for version 0.20.0 documenting the new Workzone Standard support.
  • package.json / package-lock.json: Bumped version from 0.19.0 to 0.20.0.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.29.26

  • Event Trigger: pull_request.ready_for_review
  • Summary Prompt: Default Prompt
  • Correlation ID: b36b6080-9707-11f1-9bf2-503d2084edf3
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has multiple substantive bugs already flagged by prior reviewers (undefined {{strippedAppName}} in both templates, hasWorkzoneStandard never being set by readProject(), and test isolation pollution from the shared bookshop directory). The one new issue I found and commented on is a duplicate redundant assignment of project.workzoneProviderId outside its guard, which should be removed to avoid confusion. The author should address all open comments before merging.

PR Bot Information

Version: 1.29.26

  • Event Trigger: pull_request.ready_for_review
  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: b36b6080-9707-11f1-9bf2-503d2084edf3

Comment thread lib/add.js Outdated
Co-authored-by: hyperspace-pr-bot[bot] <209611008+hyperspace-pr-bot[bot]@users.noreply.github.com>

@Pavan-SAP Pavan-SAP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. ✅

@anirudhprasad-sap
anirudhprasad-sap enabled auto-merge (squash) August 18, 2026 09:36
@anirudhprasad-sap
anirudhprasad-sap merged commit 47d5165 into main Aug 18, 2026
7 checks passed
@anirudhprasad-sap
anirudhprasad-sap deleted the workzone branch August 18, 2026 09:37
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants