Skip to content
This repository was archived by the owner on May 27, 2026. It is now read-only.

Fix/freeze literal string#37

Merged
fonji merged 8 commits into
masterfrom
fix/freeze_literal_string
May 21, 2026
Merged

Fix/freeze literal string#37
fonji merged 8 commits into
masterfrom
fix/freeze_literal_string

Conversation

@fonji

@fonji fonji commented May 20, 2026

Copy link
Copy Markdown

Fixes hubspot-api-ruby-0.22.1/lib/hubspot/connection.rb:95: warning: literal string will be frozen in the future
Adds magical comments to ensure it does not happen again
Lints changed files

@fonji fonji self-assigned this May 20, 2026
@fonji

fonji commented May 20, 2026

Copy link
Copy Markdown
Author

@ur5us please let me know what you think 🙇

@ur5us

ur5us commented May 20, 2026

Copy link
Copy Markdown

@fonji For consistency and to avoid doc generators getting confused I’d always add a blank line after every # frozen_string_literal: true comment. Otherwise this is a good change overall IMO.

Comment thread lib/hubspot/connection.rb Outdated
@fonji fonji merged commit 54082a1 into master May 21, 2026
6 checks passed
@fonji fonji deleted the fix/freeze_literal_string branch May 21, 2026 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants