Hide Windows console windows for headed-launch supervisors - #6
Open
bartholomewtj wants to merge 1 commit into
Open
Hide Windows console windows for headed-launch supervisors#6bartholomewtj wants to merge 1 commit into
bartholomewtj wants to merge 1 commit into
Conversation
DETACHED_PROCESS gives python.exe a new visible cmd window and makes CREATE_NO_WINDOW a no-op. Spawn the supervisor with pythonw.exe and CREATE_NO_WINDOW so the helper outlives launch without a leftover console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a headed
chrome-agent launchleaves a visible cmd window for the life of the browser (and sometimes after). That window is the per-instance supervisor (python.exe -m chrome_agent.supervisor).DETACHED_PROCESSis the wrong flag for this: for console apps it allocates a new console, and it also makesCREATE_NO_WINDOWa no-op.This PR:
pythonw.exewhen it sits next to the interpreterCREATE_NO_WINDOW | CREATE_NEW_PROCESS_GROUP(andSW_HIDE) instead ofDETACHED_PROCESSspawn_supervisorwiringVerified on Windows 11: headed launch has no supervisor console;
stopreaps thepythonwprocess.Once this is on PyPI,
uv tool upgrade chrome-agentkeeps the fix instead of wiping a local patch.