Fix host tests silently not running with Percy#5295
Merged
Conversation
Percy bundles its own Chromium and downloads + unzips it on first use via extract-zip, whose extraction hangs indefinitely on Node 24.x. `percy exec` runs the wrapped test command only after its browser starts, so the hang left the host suite never running: no TAP, no testem, no junit/host-N.xml. Each shard's junit upload then warned "No files were found" and the merge job failed at `ls all-host-reports` with nothing to merge. Point Percy at the system Chrome via PERCY_BROWSER_EXECUTABLE (honored by @percy/core, which then skips the download), reusing the path already resolved for PUPPETEER_EXECUTABLE_PATH. Also assert junit/host-N.xml exists after the suite step, so a suite that never runs fails the shard loudly instead of reporting green with zero tests executed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc003c7c5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The host-test job runs with BOXEL_ENVIRONMENT=ci, so env-vars.sh takes the env-mode branch and skipped the PERCY_BROWSER_EXECUTABLE assignment, which sat in the standard-mode else — Percy kept downloading its own Chromium and the Node 24 extract-zip hang could still produce zero-test shards. Factor the system-Chrome detection into a helper and set PERCY_BROWSER_EXECUTABLE outside both branches, reusing PUPPETEER_EXECUTABLE_PATH when standard mode set it and otherwise detecting the system Chrome directly. The env-mode prerender's own browser selection is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percy has problems with the new Node version similar to Puppeteer (#5294).
This changes Percy to use the same Chromium as Puppeteer, bypassing that.
Also, this makes host shards fail when no tests have run, as in #5254 I saw
false positives that only the merge job indicated: