Skip to content

Add fields - #1

Closed
petski wants to merge 1 commit into
catalyst-cloud:catalyst-v1.08bfrom
petski:feature-add-fields
Closed

Add fields#1
petski wants to merge 1 commit into
catalyst-cloud:catalyst-v1.08bfrom
petski:feature-add-fields

Conversation

@petski

@petski petski commented Dec 29, 2019

Copy link
Copy Markdown

Add fields: Attachments.FriendlyContentLength, Transaction.Content, Attachments.*.

I'm trying to create feature parity for /REST/1.0/ticket/:id/history?format=l in REST 2.0 (but with TxnCustomFields added). With this patch installed, I succeed to do so with the following URL:

/REST/2.0/ticket/:id/history?fields=id,Type,Creator,Created,CustomFields,Content,Attachments&fields[CustomFields]=Name,Values&fields[Attachments]=ContentType,Filename,FriendlyContentLength

Please let me know your thoughts.

@puck

puck commented Jan 3, 2020

Copy link
Copy Markdown

Fantastic!

I've cherry-picked this commit onto this branch: https://github.com/catalyst-cloud/rt-extension-rest2/tree/search-fields-groups

What would be wonderful to see is some test cases which exercise these new fields.

Cheers,
Andrew

@puck

puck commented May 2, 2020

Copy link
Copy Markdown

Hey @sunnavy you might be interested in this PR as well. I haven't looked into the test cases for this yet, and @petski doesn't appear to have added any to his branch.

@sunnavy

sunnavy commented May 4, 2020

Copy link
Copy Markdown

@puck I can take a look at it a bit later, and it'll be great if you can create a PR to our repo for it.

Thanks!

@petski

petski commented Jun 28, 2020

Copy link
Copy Markdown
Author

"Copied" PR to bestpractical#39. Will close here and will welcome you to continue this thread on the new location.

@petski petski closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants