Skip to content

menubar: стилизация, сторисы, обёртки#42

Merged
AxyIX merged 13 commits into
feature/styles-debugfrom
menu.menubar
Jun 1, 2026
Merged

menubar: стилизация, сторисы, обёртки#42
AxyIX merged 13 commits into
feature/styles-debugfrom
menu.menubar

Conversation

@khaliulin
Copy link
Copy Markdown
Contributor

No description provided.

@Component({
selector: 'menubar',
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот это бы кстати распространить на все компоненты и стори тоже. что бы видеть, что это всё работает в онпуш. не все и не всегда этот режим включают, но работать в нём должно.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX ChangeDetectionStrategy.OnPush добавлен на все компоненты (15 lib + 73 stories).

a5e1f17

<p-menubar [model]="items">
<ng-template pTemplate="item" let-item let-hasSubmenu="hasSubmenu" let-root="root">
<a class="p-menubar-item-link flex items-center gap-2">
<span *ngIf="item.icon" [class]="'p-menubar-item-icon ' + item.icon"></span>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше через @if

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX *ngIf заменён на @if во всём шаблоне menubar-custom.

283738a

@Component({
selector: 'app-menubar-custom',
standalone: true,
imports: [Menubar, Badge, NgIf, SharedModule],
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

импорт здесь ngif тогда убрать

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX Импорт NgIf убран из файла и из массива imports компонента.

d7a59bc

khaliulin and others added 12 commits April 20, 2026 10:05
# Conflicts:
#	.gitignore
#	src/lib/components/checkbox/checkbox.component.ts
#	src/lib/providers/prime-preset/tokens/components/menubar.ts
#	src/stories/components/avatar/examples/avatar-group.component.ts
#	src/stories/components/avatar/examples/avatar-icon-badge.component.ts
#	src/stories/components/avatar/examples/avatar-icon.component.ts
#	src/stories/components/avatar/examples/avatar-image-badge.component.ts
#	src/stories/components/avatar/examples/avatar-image.component.ts
#	src/stories/components/avatar/examples/avatar-label-badge.component.ts
#	src/stories/components/avatar/examples/avatar-label.component.ts
#	src/stories/components/avatar/examples/avatar-shapes.component.ts
#	src/stories/components/avatar/examples/avatar-sizes.component.ts
#	src/stories/components/badge/examples/badge-dot.component.ts
#	src/stories/components/badge/examples/badge-severity.component.ts
#	src/stories/components/badge/examples/badge-sizes.component.ts
#	src/stories/components/breadcrumb/examples/breadcrumb-basic.component.ts
#	src/stories/components/breadcrumb/examples/breadcrumb-icons-only.component.ts
#	src/stories/components/button/examples/button-sizes.component.ts
#	src/stories/components/checkbox/examples/checkbox-custom-label.component.ts
#	src/stories/components/checkbox/examples/checkbox-disabled.component.ts
#	src/stories/components/checkbox/examples/checkbox-group.component.ts
#	src/stories/components/checkbox/examples/checkbox-indeterminate.component.ts
#	src/stories/components/checkbox/examples/checkbox-invalid.component.ts
#	src/stories/components/checkbox/examples/checkbox-label.component.ts
#	src/stories/components/chip/examples/chip-disabled.component.ts
#	src/stories/components/chip/examples/chip-removable-with-icon.component.ts
#	src/stories/components/chip/examples/chip-removable.component.ts
#	src/stories/components/chip/examples/chip-with-icon.component.ts
#	src/stories/components/dialog/examples/dialog-default.component.ts
#	src/stories/components/dialog/examples/dialog-dynamic.component.ts
#	src/stories/components/dialog/examples/dialog-extra-large.component.ts
#	src/stories/components/dialog/examples/dialog-large.component.ts
#	src/stories/components/dialog/examples/dialog-no-header.component.ts
#	src/stories/components/dialog/examples/dialog-no-modal.component.ts
#	src/stories/components/dialog/examples/dialog-small.component.ts
#	src/stories/components/divider/examples/divider-align-left.component.ts
#	src/stories/components/divider/examples/divider-with-content.component.ts
#	src/stories/components/divider/examples/divider-with-icon.component.ts
#	src/stories/components/metergroup/examples/metergroup-basic.component.ts
#	src/stories/components/metergroup/examples/metergroup-horizontal.component.ts
#	src/stories/components/metergroup/examples/metergroup-icon.component.ts
#	src/stories/components/metergroup/examples/metergroup-label-start.component.ts
#	src/stories/components/metergroup/examples/metergroup-label-vertical.component.ts
#	src/stories/components/metergroup/examples/metergroup-vertical.component.ts
#	src/stories/components/progressbar/examples/progressbar-indeterminate.component.ts
#	src/stories/components/progressbar/examples/progressbar-no-label.component.ts
#	src/stories/components/progressspinner/examples/progressspinner-monochrome.component.ts
#	src/stories/components/progressspinner/examples/progressspinner-sizes.component.ts
#	src/stories/components/radiobutton/examples/radiobutton-disabled.component.ts
#	src/stories/components/radiobutton/examples/radiobutton-group.component.ts
#	src/stories/components/radiobutton/examples/radiobutton-invalid.component.ts
#	src/stories/components/rating/examples/rating-disabled.component.ts
#	src/stories/components/rating/examples/rating-readonly.component.ts
#	src/stories/components/skeleton/examples/skeleton-card-placeholder.component.ts
#	src/stories/components/skeleton/examples/skeleton-circle.component.ts
#	src/stories/components/skeleton/examples/skeleton-no-animation.component.ts
#	src/stories/components/skeleton/examples/skeleton-rectangles.component.ts
#	src/stories/components/slider/examples/slider-disabled.component.ts
#	src/stories/components/slider/examples/slider-range.component.ts
#	src/stories/components/slider/examples/slider-step.component.ts
#	src/stories/components/slider/examples/slider-vertical.component.ts
#	src/stories/components/tag/examples/tag-icon.component.ts
#	src/stories/components/tag/examples/tag-rounded.component.ts
#	src/stories/components/tag/examples/tag-severity.component.ts
@AxyIX AxyIX merged commit 4f4a671 into feature/styles-debug Jun 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants