feat: replace FF_SALESFORCE_CONTACT env var - #2735
Merged
Merged
Conversation
🧪 Review environmenthttps://7mj63vcb63jznlrcil2ehv343u0lgaac.lambda-url.ca-central-1.on.aws/ |
patheard
force-pushed
the
feat/remove-salesforce
branch
from
August 7, 2026 20:27
a1cac3e to
98060b0
Compare
patheard
force-pushed
the
feat/remove-salesforce
branch
from
August 26, 2026 13:21
9dd10e9 to
5df53bc
Compare
patheard
marked this pull request as ready for review
August 26, 2026 13:58
andrewleith
approved these changes
Aug 27, 2026
andrewleith
left a comment
andrewleith
left a comment
Member
There was a problem hiding this comment.
LGTM - since the env vars GC_ORGANISATIONS_BUCKET_NAME and GC_ORGANISATIONS_FILENAME will not be changing here, the app will continue to load and show the org list from the s3 bucket and/or the fallback file. ✅
Thanks for doing this Pat!
Replace the feature flag with an inferred `IS_GC_ORGANISATIONS` boolean based on the existence of the GC organisation bucket and filename. This is being done as part of the Notify Salesforce disconnect.
patheard
force-pushed
the
feat/remove-salesforce
branch
from
August 28, 2026 01:33
5df53bc to
91ec7c3
Compare
This was referenced Aug 28, 2026
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Replace the feature flag with an inferred
IS_GC_ORGANISATIONSboolean based on the existence of the GC organisation bucket and filename.This is being done as part of the Notify Salesforce disconnect.
Related