chore: remove broken roadmap redirect from navigation

[andrewleith]

Summary | Résumé

This pull request removes the internal redirect and navigation references for the /features/roadmap route, effectively deprecating or removing the roadmap feature from the application's navigation and routing.

Navigation and routing updates:

• Removed the /features/roadmap internal redirect route from index.py, so users can no longer access it via that endpoint.
• Removed "redirect_roadmap" from both HeaderNavigation and OrgNavigation in navigation.py, so the roadmap is no longer present in the application's navigation menus. [1] [2]

Test instructions | Instructions pour tester la modification

• Going to /features/roadmap does not result in a 500 error

[github-actions]

🧪 Review environment

https://vcbxouxfl5fiku2d46d42qt6ha0wwagf.lambda-url.ca-central-1.on.aws/

[jimleroyer]

LGTM

[Copilot]

Pull request overview

This PR removes the legacy /features/roadmap internal redirect endpoint and its related navigation endpoint references, to prevent users from hitting a broken redirect path.

Changes:

• Removed the /features/roadmap internal redirect route registration from app/main/views/index.py.
• Removed redirect_roadmap from navigation endpoint exclusion lists in HeaderNavigation and OrgNavigation (app/navigation.py).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
app/navigation.py	Drops redirect_roadmap from navigation endpoint lists so the removed endpoint is no longer referenced there.
app/main/views/index.py	Removes the /features/roadmap redirect route decorator so that endpoint is no longer registered.

Suppressed comments (2)

app/main/views/index.py:378

• With the /features/roadmap route removed, requests to /features/roadmap will now fall through to the catch-all page_content route and trigger WordPress lookups. Because get_page_by_slug_with_cache does not cache misses, a missing slug results in at least 2 WP calls per request (initial lookup + _try_alternate_language) before returning 404, which can create unnecessary upstream load if this URL is still being hit.

# --- Internal Redirects --- #
@main.route("/features/email", endpoint="redirect_email")
@main.route("/features/sms", endpoint="redirect_sms")
@main.route("/features/letters", endpoint="redirect_letters")
def old_page_redirects():

app/main/views/index.py:378

• This change removes the explicit /features/roadmap redirect behavior, but there’s no regression test covering that /features/roadmap no longer 500s (similar redirect routes are covered in tests/app/main/views/test_index.py). Adding a test that requests /features/roadmap and asserts a non-500 outcome (ideally a stable status like 404 or a specific redirect) would prevent this bug from reappearing.

# --- Internal Redirects --- #
@main.route("/features/email", endpoint="redirect_email")
@main.route("/features/sms", endpoint="redirect_sms")
@main.route("/features/letters", endpoint="redirect_letters")
def old_page_redirects():

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.