fix gitconfig jumana - #3018
Draft
jzbahrai wants to merge 1 commit into
Draft
Conversation
jzbahrai
marked this pull request as ready for review
August 20, 2026 14:49
jzbahrai
marked this pull request as draft
August 20, 2026 14:49
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the devcontainer setup so the container can read a developer’s host Git configuration by bind-mounting ~/.gitconfig and including it from the container’s writable global gitconfig.
Changes:
- Bind-mount host
${HOME}/.gitconfiginto the devcontainer as/home/vscode/.gitconfig-host(read-only). - Update the devcontainer entrypoint to add an
include.pathto/home/vscode/.gitconfig-host(only if present and not already included).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .devcontainer/scripts/notify-dev-entrypoint.sh | Conditionally adds a global include.path entry so git inside the container picks up the mounted host gitconfig. |
| .devcontainer/docker-compose.yml | Adds a bind mount for the host ~/.gitconfig into the devcontainer (read-only). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| REDIS_URL: redis://redis:6380 | ||
| volumes: | ||
| - ..:/workspace:cached | ||
| - ${HOME}/.gitconfig:/home/vscode/.gitconfig-host:ro |
| REDIS_URL: redis://redis:6380 | ||
| volumes: | ||
| - ..:/workspace:cached | ||
| - ${HOME}/.gitconfig:/home/vscode/.gitconfig-host:ro |
Comment on lines
+119
to
+123
| if [ -f /home/vscode/.gitconfig-host ]; then | ||
| if ! git config --global --get-all include.path | grep -Fxq /home/vscode/.gitconfig-host; then | ||
| git config --global --add include.path /home/vscode/.gitconfig-host | ||
| fi | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
TODO: 1-3 sentence description of the changed you're proposing.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur